Title: [145048] trunk
- Revision
- 145048
- Author
- [email protected]
- Date
- 2013-03-07 00:27:14 -0800 (Thu, 07 Mar 2013)
Log Message
Web Inspector: NavigatorView should show (program) for uiSourceCodes with empty name.
https://bugs.webkit.org/show_bug.cgi?id=111691
Reviewed by Alexander Pavlov.
Source/WebCore:
Made String.prototype methods return string literal, not String object.
* inspector/front-end/utilities.js:
(String.prototype.escapeCharacters):
LayoutTests:
* inspector/debugger/navigator-view-expected.txt:
* inspector/debugger/navigator-view.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (145047 => 145048)
--- trunk/LayoutTests/ChangeLog 2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/LayoutTests/ChangeLog 2013-03-07 08:27:14 UTC (rev 145048)
@@ -1,3 +1,13 @@
+2013-03-07 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: NavigatorView should show (program) for uiSourceCodes with empty name.
+ https://bugs.webkit.org/show_bug.cgi?id=111691
+
+ Reviewed by Alexander Pavlov.
+
+ * inspector/debugger/navigator-view-expected.txt:
+ * inspector/debugger/navigator-view.html:
+
2013-03-06 Takashi Sakamoto <[email protected]>
Box-shadow displayed improperly with border-radius.
Modified: trunk/LayoutTests/inspector/debugger/navigator-view-expected.txt (145047 => 145048)
--- trunk/LayoutTests/inspector/debugger/navigator-view-expected.txt 2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/LayoutTests/inspector/debugger/navigator-view-expected.txt 2013-03-07 08:27:14 UTC (rev 145048)
@@ -100,6 +100,7 @@
?a=b
very_looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo…
example.com
+ (program)
?a=b
localhost:8080
LayoutTests/inspector
Modified: trunk/LayoutTests/inspector/debugger/navigator-view.html (145047 => 145048)
--- trunk/LayoutTests/inspector/debugger/navigator-view.html 2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/LayoutTests/inspector/debugger/navigator-view.html 2013-03-07 08:27:14 UTC (rev 145048)
@@ -51,6 +51,7 @@
addUISourceCode(rootURL + "foo/bar/contentScript2.js?a=1", true);
addUISourceCode(rootURL + "foo/bar/contentScript.js?a=2", true);
addUISourceCode(rootURL + "foo/bar/contentScript.js?a=1", true);
+ addUISourceCode("http://example.com/", false);
addUISourceCode("http://example.com/?a=b", false);
addUISourceCode("?a=b", false);
addUISourceCode("very_looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong_url", false);
Modified: trunk/Source/WebCore/ChangeLog (145047 => 145048)
--- trunk/Source/WebCore/ChangeLog 2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/Source/WebCore/ChangeLog 2013-03-07 08:27:14 UTC (rev 145048)
@@ -1,3 +1,15 @@
+2013-03-07 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: NavigatorView should show (program) for uiSourceCodes with empty name.
+ https://bugs.webkit.org/show_bug.cgi?id=111691
+
+ Reviewed by Alexander Pavlov.
+
+ Made String.prototype methods return string literal, not String object.
+
+ * inspector/front-end/utilities.js:
+ (String.prototype.escapeCharacters):
+
2013-03-07 Eugene Klyuchnikov <[email protected]>
Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (145047 => 145048)
--- trunk/Source/WebCore/inspector/front-end/utilities.js 2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js 2013-03-07 08:27:14 UTC (rev 145048)
@@ -82,7 +82,7 @@
}
if (!foundChar)
- return this;
+ return String(this);
var result = "";
for (var i = 0; i < this.length; ++i) {
@@ -117,7 +117,7 @@
String.prototype.trimMiddle = function(maxLength)
{
if (this.length <= maxLength)
- return this;
+ return String(this);
var leftHalf = maxLength >> 1;
var rightHalf = maxLength - leftHalf - 1;
return this.substr(0, leftHalf) + "\u2026" + this.substr(this.length - rightHalf, rightHalf);
@@ -126,7 +126,7 @@
String.prototype.trimEnd = function(maxLength)
{
if (this.length <= maxLength)
- return this;
+ return String(this);
return this.substr(0, maxLength - 1) + "\u2026";
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
