Title: [145146] trunk/Tools
Revision
145146
Author
[email protected]
Date
2013-03-07 15:48:40 -0800 (Thu, 07 Mar 2013)

Log Message

showAllRuns checkbox no longer works on the stats dashboard
https://bugs.webkit.org/show_bug.cgi?id=111673

Reviewed by Ojan Vafai.

Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
so we were trying to index into an undefined object.

* TestResultServer/static-dashboards/dashboard_base.js:
(invalidateQueryParameters):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (145145 => 145146)


--- trunk/Tools/ChangeLog	2013-03-07 23:45:27 UTC (rev 145145)
+++ trunk/Tools/ChangeLog	2013-03-07 23:48:40 UTC (rev 145146)
@@ -1,3 +1,16 @@
+2013-03-07  Julie Parent  <[email protected]>
+
+        showAllRuns checkbox no longer works on the stats dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=111673
+
+        Reviewed by Ojan Vafai.
+
+        Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
+        so we were trying to index into an undefined object.
+        
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        (invalidateQueryParameters):
+
 2013-03-07  Mark Pilgrim  <[email protected]>
 
         [Chromium] Update #include for WebStorageNamespace.h

Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (145145 => 145146)


--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2013-03-07 23:45:27 UTC (rev 145145)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2013-03-07 23:48:40 UTC (rev 145146)
@@ -503,7 +503,7 @@
     for (var key in queryParamsAsState) {
         if (key in CROSS_DB_INVALIDATING_PARAMETERS)
             delete g_crossDashboardState[CROSS_DB_INVALIDATING_PARAMETERS[key]];
-        if (key in DB_SPECIFIC_INVALIDATING_PARAMETERS)
+        if (DB_SPECIFIC_INVALIDATING_PARAMETERS && key in DB_SPECIFIC_INVALIDATING_PARAMETERS)
             delete g_currentState[DB_SPECIFIC_INVALIDATING_PARAMETERS[key]];
     }
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to