Title: [145154] trunk/Source
Revision
145154
Author
[email protected]
Date
2013-03-07 16:53:42 -0800 (Thu, 07 Mar 2013)

Log Message

Reduce page cache size on Mac
https://bugs.webkit.org/show_bug.cgi?id=111795

Rubber stamped by Geoff Garen

5 entries is unnecessarily large; research show 3 should suffice.
On a low memory warning we should clear this completely.

Source/WebCore: 

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
    - clear the page cache completely

Source/WebKit2: 

* Shared/CacheModel.cpp:
(WebKit::calculateCacheSizes):
    - reduce maximum to 3.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (145153 => 145154)


--- trunk/Source/WebCore/ChangeLog	2013-03-08 00:44:04 UTC (rev 145153)
+++ trunk/Source/WebCore/ChangeLog	2013-03-08 00:53:42 UTC (rev 145154)
@@ -1,3 +1,17 @@
+2013-03-07  Gavin Barraclough  <[email protected]>
+
+        Reduce page cache size on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=111795
+
+        Rubber stamped by Geoff Garen
+
+        5 entries is unnecessarily large; research show 3 should suffice.
+        On a low memory warning we should clear this completely.
+
+        * platform/mac/MemoryPressureHandlerMac.mm:
+        (WebCore::MemoryPressureHandler::releaseMemory):
+            - clear the page cache completely
+
 2013-03-07  Simon Fraser  <[email protected]>
 
         Rename Mac's TileCache to TileController, and WebTileCacheLayer to WebTiledBackingLayer

Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (145153 => 145154)


--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2013-03-08 00:44:04 UTC (rev 145153)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2013-03-08 00:53:42 UTC (rev 145154)
@@ -145,7 +145,7 @@
 void MemoryPressureHandler::releaseMemory(bool critical)
 {
     int savedPageCacheCapacity = pageCache()->capacity();
-    pageCache()->setCapacity(critical ? 0 : pageCache()->pageCount() / 2);
+    pageCache()->setCapacity(0);
     pageCache()->setCapacity(savedPageCacheCapacity);
 
     NSURLCache *nsurlCache = [NSURLCache sharedURLCache];

Modified: trunk/Source/WebKit2/ChangeLog (145153 => 145154)


--- trunk/Source/WebKit2/ChangeLog	2013-03-08 00:44:04 UTC (rev 145153)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-08 00:53:42 UTC (rev 145154)
@@ -1,3 +1,17 @@
+2013-03-07  Gavin Barraclough  <[email protected]>
+
+        Reduce page cache size on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=111795
+
+        Rubber stamped by Geoff Garen
+
+        5 entries is unnecessarily large; research show 3 should suffice.
+        On a low memory warning we should clear this completely.
+
+        * Shared/CacheModel.cpp:
+        (WebKit::calculateCacheSizes):
+            - reduce maximum to 3.
+
 2013-03-07  Anders Carlsson  <[email protected]>
 
         Add a didFocusTextField callback to the injected bundle form client

Modified: trunk/Source/WebKit2/Shared/CacheModel.cpp (145153 => 145154)


--- trunk/Source/WebKit2/Shared/CacheModel.cpp	2013-03-08 00:44:04 UTC (rev 145153)
+++ trunk/Source/WebKit2/Shared/CacheModel.cpp	2013-03-08 00:53:42 UTC (rev 145154)
@@ -108,17 +108,14 @@
     }
     case CacheModelPrimaryWebBrowser: {
         // Page cache capacity (in pages)
-        // (Research indicates that value / page drops substantially after 3 pages.)
-        if (memorySize >= 2048)
-            pageCacheCapacity = 5;
-        else if (memorySize >= 1024)
-            pageCacheCapacity = 4;
-        else if (memorySize >= 512)
+        if (memorySize >= 1024)
             pageCacheCapacity = 3;
-        else if (memorySize >= 256)
+        else if (memorySize >= 512)
             pageCacheCapacity = 2;
-        else
+        else if (memorySize >= 256)
             pageCacheCapacity = 1;
+        else
+            pageCacheCapacity = 0;
 
         // Object cache capacities (in bytes)
         // (Testing indicates that value / MB depends heavily on content and
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to