Title: [145352] trunk/Source/WebCore
- Revision
- 145352
- Author
- [email protected]
- Date
- 2013-03-11 03:36:21 -0700 (Mon, 11 Mar 2013)
Log Message
Make sure that CSSSelector::setValue() is never called after parsing its pseudoType.
https://bugs.webkit.org/show_bug.cgi?id=111957
Reviewed by Hajime Morrita.
It'd be nice to have an assertion here since
CSSSelector::pseudoType() will never parse a new value after it
parses a value and m_pseudoType is set to non-PseudoNotParsed.
No new tests (no change in behaviour).
* css/CSSSelector.h:
(WebCore::CSSSelector::setValue):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (145351 => 145352)
--- trunk/Source/WebCore/ChangeLog 2013-03-11 09:55:50 UTC (rev 145351)
+++ trunk/Source/WebCore/ChangeLog 2013-03-11 10:36:21 UTC (rev 145352)
@@ -1,3 +1,19 @@
+2013-03-11 Hayato Ito <[email protected]>
+
+ Make sure that CSSSelector::setValue() is never called after parsing its pseudoType.
+ https://bugs.webkit.org/show_bug.cgi?id=111957
+
+ Reviewed by Hajime Morrita.
+
+ It'd be nice to have an assertion here since
+ CSSSelector::pseudoType() will never parse a new value after it
+ parses a value and m_pseudoType is set to non-PseudoNotParsed.
+
+ No new tests (no change in behaviour).
+
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::setValue):
+
2013-03-11 Takashi Sakamoto <[email protected]>
[Refactoring] Implement RuleCollector
Modified: trunk/Source/WebCore/css/CSSSelector.h (145351 => 145352)
--- trunk/Source/WebCore/css/CSSSelector.h 2013-03-11 09:55:50 UTC (rev 145351)
+++ trunk/Source/WebCore/css/CSSSelector.h 2013-03-11 10:36:21 UTC (rev 145352)
@@ -357,6 +357,7 @@
inline void CSSSelector::setValue(const AtomicString& value)
{
ASSERT(m_match != Tag);
+ ASSERT(m_pseudoType == PseudoNotParsed);
// Need to do ref counting manually for the union.
if (m_hasRareData) {
if (m_data.m_rareData->m_value)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
