Title: [145498] trunk/LayoutTests
Revision
145498
Author
[email protected]
Date
2013-03-12 01:25:21 -0700 (Tue, 12 Mar 2013)

Log Message

Web Inspector: Several inspector tests are flaky beacuse of beforeonload event handler.
https://bugs.webkit.org/show_bug.cgi?id=112111

Reviewed by Alexander Pavlov.

Added removeEventListener call.
Beforeunload message was updated so that it is possible to find it's source from it.

* inspector-protocol/page/_javascript_DialogEvents-expected.txt:
* inspector-protocol/page/_javascript_DialogEvents.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (145497 => 145498)


--- trunk/LayoutTests/ChangeLog	2013-03-12 08:07:32 UTC (rev 145497)
+++ trunk/LayoutTests/ChangeLog	2013-03-12 08:25:21 UTC (rev 145498)
@@ -1,3 +1,16 @@
+2013-03-12  Vsevolod Vlasov  <[email protected]>
+
+        Web Inspector: Several inspector tests are flaky beacuse of beforeonload event handler.
+        https://bugs.webkit.org/show_bug.cgi?id=112111
+
+        Reviewed by Alexander Pavlov.
+
+        Added removeEventListener call.
+        Beforeunload message was updated so that it is possible to find it's source from it.
+
+        * inspector-protocol/page/_javascript_DialogEvents-expected.txt:
+        * inspector-protocol/page/_javascript_DialogEvents.html:
+
 2013-03-12  Zan Dobersek  <[email protected]>
 
         Unreviewed GTK gardening.

Modified: trunk/LayoutTests/inspector-protocol/page/_javascript_DialogEvents-expected.txt (145497 => 145498)


--- trunk/LayoutTests/inspector-protocol/page/_javascript_DialogEvents-expected.txt	2013-03-12 08:07:32 UTC (rev 145497)
+++ trunk/LayoutTests/inspector-protocol/page/_javascript_DialogEvents-expected.txt	2013-03-12 08:25:21 UTC (rev 145498)
@@ -1,8 +1,8 @@
-CONFIRM NAVIGATION: beforeunload
+CONFIRM NAVIGATION: beforeunload in _javascript_DialogEvents
 ALERT: alert
 CONFIRM: confirm
 PROMPT: prompt, default text: 
-Opening with message: beforeunload
+Opening with message: beforeunload in _javascript_DialogEvents
 Closed
 Opening with message: alert
 Closed

Modified: trunk/LayoutTests/inspector-protocol/page/_javascript_DialogEvents.html (145497 => 145498)


--- trunk/LayoutTests/inspector-protocol/page/_javascript_DialogEvents.html	2013-03-12 08:07:32 UTC (rev 145497)
+++ trunk/LayoutTests/inspector-protocol/page/_javascript_DialogEvents.html	2013-03-12 08:25:21 UTC (rev 145498)
@@ -7,7 +7,8 @@
 
 function onBeforeUnload()
 {
-    return "beforeunload";
+    window.removeEventListener("beforeunload", onBeforeUnload);
+    return "beforeunload in _javascript_DialogEvents";
 }
 
 function test()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to