Title: [145625] trunk/Source/WebKit2
Revision
145625
Author
[email protected]
Date
2013-03-12 17:09:55 -0700 (Tue, 12 Mar 2013)

Log Message

WKView -printOperationWithPrintInfo:forFrame: doesn’t use the print info that is 
passed in
https://bugs.webkit.org/show_bug.cgi?id=112212
-and corresponding-
<rdar://problem/12994883>

Reviewed by Anders Carlsson.

We should call [NSPrintOperation printOperationWithView: printInfo:] to use the 
printInfo parameter instead of [NSPrintOperation printOperationWithView:] which 
will just use the sharedPrintInfo.
* UIProcess/API/mac/WKView.mm:
(-[WKView printOperationWithPrintInfo:forFrame:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (145624 => 145625)


--- trunk/Source/WebKit2/ChangeLog	2013-03-13 00:06:23 UTC (rev 145624)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-13 00:09:55 UTC (rev 145625)
@@ -1,3 +1,19 @@
+2013-03-12  Beth Dakin  <[email protected]>
+
+        WKView -printOperationWithPrintInfo:forFrame: doesn’t use the print info that is 
+        passed in
+        https://bugs.webkit.org/show_bug.cgi?id=112212
+        -and corresponding-
+        <rdar://problem/12994883>
+
+        Reviewed by Anders Carlsson.
+
+        We should call [NSPrintOperation printOperationWithView: printInfo:] to use the 
+        printInfo parameter instead of [NSPrintOperation printOperationWithView:] which 
+        will just use the sharedPrintInfo.
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView printOperationWithPrintInfo:forFrame:]):
+
 2013-03-12  Geoffrey Garen  <[email protected]>
 
         Moved RunLoopTimer and SchedulePair to WTF

Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (145624 => 145625)


--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2013-03-13 00:06:23 UTC (rev 145624)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2013-03-13 00:09:55 UTC (rev 145625)
@@ -3207,7 +3207,7 @@
         // printing), this function should return nil.
         RetainPtr<WKPrintingView> printingView(AdoptNS, [[WKPrintingView alloc] initWithFrameProxy:toImpl(frameRef) view:self]);
         // NSPrintOperation takes ownership of the view.
-        NSPrintOperation *printOperation = [NSPrintOperation printOperationWithView:printingView.get()];
+        NSPrintOperation *printOperation = [NSPrintOperation printOperationWithView:printingView.get() printInfo:printInfo];
         [printOperation setCanSpawnSeparateThread:YES];
         [printOperation setJobTitle:toImpl(frameRef)->title()];
         printingView->_printOperation = printOperation;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to