Title: [145651] trunk/Source/WebKit/chromium
- Revision
- 145651
- Author
- [email protected]
- Date
- 2013-03-12 18:19:05 -0700 (Tue, 12 Mar 2013)
Log Message
[Chromium] WebFrame event listener APIs are unused and can be removed
https://bugs.webkit.org/show_bug.cgi?id=112189
Reviewed by Darin Fisher.
As far as I can tell, there are no callers for these APIs. They appear
to have been added for out-of-process postMessages, but those are now
implemented using a different mechanism.
* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (145650 => 145651)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-13 01:17:02 UTC (rev 145650)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-13 01:19:05 UTC (rev 145651)
@@ -1,3 +1,20 @@
+2013-03-12 Adam Barth <[email protected]>
+
+ [Chromium] WebFrame event listener APIs are unused and can be removed
+ https://bugs.webkit.org/show_bug.cgi?id=112189
+
+ Reviewed by Darin Fisher.
+
+ As far as I can tell, there are no callers for these APIs. They appear
+ to have been added for out-of-process postMessages, but those are now
+ implemented using a different mechanism.
+
+ * public/WebFrame.h:
+ (WebFrame):
+ * src/WebFrameImpl.cpp:
+ * src/WebFrameImpl.h:
+ (WebFrameImpl):
+
2013-03-12 Sheriff Bot <[email protected]>
Unreviewed. Rolled Chromium DEPS to r187660. Requested by
Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (145650 => 145651)
--- trunk/Source/WebKit/chromium/public/WebFrame.h 2013-03-13 01:17:02 UTC (rev 145650)
+++ trunk/Source/WebKit/chromium/public/WebFrame.h 2013-03-13 01:19:05 UTC (rev 145651)
@@ -603,15 +603,7 @@
// Events --------------------------------------------------------------
- // These functions all work on the WebFrame's DOMWindow. Keep in mind
- // that these events might be generated by web content and not genuine
- // DOM events.
-
- virtual void addEventListener(const WebString& eventType,
- WebDOMEventListener*, bool useCapture) = 0;
- virtual void removeEventListener(const WebString& eventType,
- WebDOMEventListener*, bool useCapture) = 0;
- virtual bool dispatchEvent(const WebDOMEvent&) = 0;
+ // Dispatches a message event on the current DOMWindow in this WebFrame.
virtual void dispatchMessageEventWithOriginCheck(
const WebSecurityOrigin& intendedTargetOrigin,
const WebDOMEvent&) = 0;
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (145650 => 145651)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2013-03-13 01:17:02 UTC (rev 145650)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2013-03-13 01:19:05 UTC (rev 145651)
@@ -1848,26 +1848,6 @@
#endif
}
-void WebFrameImpl::addEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture)
-{
- DOMWindow* window = frame()->document()->domWindow();
- EventListenerWrapper* listenerWrapper = listener->createEventListenerWrapper(eventType, useCapture, window);
- window->addEventListener(eventType, adoptRef(listenerWrapper), useCapture);
-}
-
-void WebFrameImpl::removeEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture)
-{
- DOMWindow* window = frame()->document()->domWindow();
- EventListenerWrapper* listenerWrapper = listener->getEventListenerWrapper(eventType, useCapture, window);
- window->removeEventListener(eventType, listenerWrapper, useCapture);
-}
-
-bool WebFrameImpl::dispatchEvent(const WebDOMEvent& event)
-{
- ASSERT(!event.isNull());
- return frame()->document()->domWindow()->dispatchEvent(event);
-}
-
void WebFrameImpl::dispatchMessageEventWithOriginCheck(const WebSecurityOrigin& intendedTargetOrigin, const WebDOMEvent& event)
{
ASSERT(!event.isNull());
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.h (145650 => 145651)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.h 2013-03-13 01:17:02 UTC (rev 145650)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.h 2013-03-13 01:19:05 UTC (rev 145651)
@@ -219,11 +219,6 @@
virtual void sendOrientationChangeEvent(int orientation);
- virtual void addEventListener(const WebString& eventType,
- WebDOMEventListener*, bool useCapture);
- virtual void removeEventListener(const WebString& eventType,
- WebDOMEventListener*, bool useCapture);
- virtual bool dispatchEvent(const WebDOMEvent&);
virtual void dispatchMessageEventWithOriginCheck(
const WebSecurityOrigin& intendedTargetOrigin,
const WebDOMEvent&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
