Title: [145754] trunk/Source/WebCore
Revision
145754
Author
[email protected]
Date
2013-03-13 14:38:19 -0700 (Wed, 13 Mar 2013)

Log Message

Crash in CompositeEditCommand::insertNodeAt.
https://bugs.webkit.org/show_bug.cgi?id=112280

Reviewed by Ryosuke Niwa.

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAt): Fix incorrect cast use of toElement.
Subsitute with toContainerNode.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (145753 => 145754)


--- trunk/Source/WebCore/ChangeLog	2013-03-13 21:36:29 UTC (rev 145753)
+++ trunk/Source/WebCore/ChangeLog	2013-03-13 21:38:19 UTC (rev 145754)
@@ -1,3 +1,14 @@
+2013-03-13  Abhishek Arya  <[email protected]>
+
+        Crash in CompositeEditCommand::insertNodeAt.
+        https://bugs.webkit.org/show_bug.cgi?id=112280
+
+        Reviewed by Ryosuke Niwa.
+
+        * editing/CompositeEditCommand.cpp:
+        (WebCore::CompositeEditCommand::insertNodeAt): Fix incorrect cast use of toElement.
+        Subsitute with toContainerNode.
+
 2013-03-13  Brady Eidson  <[email protected]>
 
         Small ResourceLoader cleanups.

Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (145753 => 145754)


--- trunk/Source/WebCore/editing/CompositeEditCommand.cpp	2013-03-13 21:36:29 UTC (rev 145753)
+++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp	2013-03-13 21:38:19 UTC (rev 145754)
@@ -364,7 +364,7 @@
         if (child)
             insertNodeBefore(insertChild, child);
         else
-            appendNode(insertChild, toElement(refChild));
+            appendNode(insertChild, toContainerNode(refChild));
     } else if (caretMinOffset(refChild) >= offset)
         insertNodeBefore(insertChild, refChild);
     else if (refChild->isTextNode() && caretMaxOffset(refChild) > offset) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to