Title: [145908] trunk/Source/WebCore
Revision
145908
Author
[email protected]
Date
2013-03-15 09:26:47 -0700 (Fri, 15 Mar 2013)

Log Message

Web Inspector: make CPU profiler show timings using the same time unit [ms]
https://bugs.webkit.org/show_bug.cgi?id=112356

That makes it much easier to compare values when looking at the data.

Patch by Alexei Filippov <[email protected]> on 2013-03-15
Reviewed by Yury Semikhatsky.

* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (145907 => 145908)


--- trunk/Source/WebCore/ChangeLog	2013-03-15 16:24:00 UTC (rev 145907)
+++ trunk/Source/WebCore/ChangeLog	2013-03-15 16:26:47 UTC (rev 145908)
@@ -1,3 +1,15 @@
+2013-03-15  Alexei Filippov  <[email protected]>
+
+        Web Inspector: make CPU profiler show timings using the same time unit [ms]
+        https://bugs.webkit.org/show_bug.cgi?id=112356
+
+        That makes it much easier to compare values when looking at the data.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/ProfileDataGridTree.js:
+        (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
+
 2013-03-15  Peter Beverloo  <[email protected]>
 
         Implement support for nullable types in the bindings generator

Modified: trunk/Source/WebCore/inspector/front-end/ProfileDataGridTree.js (145907 => 145908)


--- trunk/Source/WebCore/inspector/front-end/ProfileDataGridTree.js	2013-03-15 16:24:00 UTC (rev 145907)
+++ trunk/Source/WebCore/inspector/front-end/ProfileDataGridTree.js	2013-03-15 16:26:47 UTC (rev 145908)
@@ -56,7 +56,10 @@
     {
         function formatMilliseconds(time)
         {
-            return Number.secondsToString(time / 1000, !Capabilities.samplingCPUProfiler);
+            if (Capabilities.samplingCPUProfiler)
+                return WebInspector.UIString("%.0f\u2009ms", time);
+            else
+                return WebInspector.UIString("%.3f\u2009ms", time);
         }
 
         var data = ""
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to