Title: [146003] trunk/Source/WebKit/chromium
Revision
146003
Author
[email protected]
Date
2013-03-16 13:47:02 -0700 (Sat, 16 Mar 2013)

Log Message

Remove redundant checks from WebInputEvent::isGestureEventType
https://bugs.webkit.org/show_bug.cgi?id=112503

Reviewed by Darin Fisher.

GesturePinchBegin, GesturePinchEnd and GesturePinchUpdate were checked
for twice.

This was found by experimenting with a potential new Clang warning.

* public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (146002 => 146003)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-16 19:43:41 UTC (rev 146002)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-16 20:47:02 UTC (rev 146003)
@@ -1,3 +1,18 @@
+2013-03-16  Hans Wennborg  <[email protected]>
+
+        Remove redundant checks from WebInputEvent::isGestureEventType
+        https://bugs.webkit.org/show_bug.cgi?id=112503
+
+        Reviewed by Darin Fisher.
+
+        GesturePinchBegin, GesturePinchEnd and GesturePinchUpdate were checked
+        for twice.
+
+        This was found by experimenting with a potential new Clang warning.
+
+        * public/WebInputEvent.h:
+        (WebKit::WebInputEvent::isGestureEventType):
+
 2013-03-15  Sheriff Bot  <[email protected]>
 
         Unreviewed.  Rolled Chromium DEPS to r188504.  Requested by

Modified: trunk/Source/WebKit/chromium/public/WebInputEvent.h (146002 => 146003)


--- trunk/Source/WebKit/chromium/public/WebInputEvent.h	2013-03-16 19:43:41 UTC (rev 146002)
+++ trunk/Source/WebKit/chromium/public/WebInputEvent.h	2013-03-16 20:47:02 UTC (rev 146003)
@@ -235,10 +235,7 @@
             || type == GestureDoubleTap
             || type == GestureTwoFingerTap
             || type == GestureLongPress
-            || type == GestureLongTap
-            || type == GesturePinchBegin
-            || type == GesturePinchEnd
-            || type == GesturePinchUpdate;
+            || type == GestureLongTap;
     }
 };
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to