Title: [146385] trunk/Source/WebCore
Revision
146385
Author
eric.carl...@apple.com
Date
2013-03-20 13:47:10 -0700 (Wed, 20 Mar 2013)

Log Message

Unreviewed, fix Mac release build.

* page/CaptionUserPreferencesMac.mm:
(WebCore::languageIdentifier):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (146384 => 146385)


--- trunk/Source/WebCore/ChangeLog	2013-03-20 20:45:22 UTC (rev 146384)
+++ trunk/Source/WebCore/ChangeLog	2013-03-20 20:47:10 UTC (rev 146385)
@@ -1,5 +1,12 @@
 2013-03-20  Eric Carlson  <eric.carl...@apple.com>
 
+        Unreviewed, fix Mac release build.
+
+        * page/CaptionUserPreferencesMac.mm:
+        (WebCore::languageIdentifier):
+
+2013-03-20  Eric Carlson  <eric.carl...@apple.com>
+
         Allow ports specific text track menu
         https://bugs.webkit.org/show_bug.cgi?id=112800
 

Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMac.mm (146384 => 146385)


--- trunk/Source/WebCore/page/CaptionUserPreferencesMac.mm	2013-03-20 20:45:22 UTC (rev 146384)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMac.mm	2013-03-20 20:47:10 UTC (rev 146385)
@@ -590,8 +590,9 @@
         return languageCode;
 
     String lowercaseLanguageCode = languageCode.lower();
-    
-    if (lowercaseLanguageCode.length() >= 3 && (lowercaseLanguageCode[2] == '_' || lowercaseLanguageCode[2] == '-'))
+
+    // Need 2U here to disambiguate String::operator[] from operator(NSString*, int)[] in a production build.
+    if (lowercaseLanguageCode.length() >= 3 && (lowercaseLanguageCode[2U] == '_' || lowercaseLanguageCode[2U] == '-'))
         lowercaseLanguageCode.truncate(2);
     
     return lowercaseLanguageCode;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to