Title: [146417] trunk/Source/WebCore
- Revision
- 146417
- Author
- [email protected]
- Date
- 2013-03-20 17:09:32 -0700 (Wed, 20 Mar 2013)
Log Message
Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
https://bugs.webkit.org/show_bug.cgi?id=112767
Reviewed by Kent Tamura.
This is part of a refactoring to move Node::disabled to HTMLFormControlElement::disabled.
The concept of disabled is just a form control element one.
HTMLMeterElement, HTMLOutputElement, and HTMLProgressElement never
have disabled() return true, so we can remove the call. In addition,
HTMLMeterElement and HTMLProgressElement no longer inherit from
HTMLFormControlElement, so we don't need to override supportsFocus.
No new tests because no behavior change.
* html/HTMLMeterElement.cpp:
* html/HTMLMeterElement.h:
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
* html/HTMLProgressElement.cpp:
* html/HTMLProgressElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (146416 => 146417)
--- trunk/Source/WebCore/ChangeLog 2013-03-21 00:08:39 UTC (rev 146416)
+++ trunk/Source/WebCore/ChangeLog 2013-03-21 00:09:32 UTC (rev 146417)
@@ -1,3 +1,27 @@
+2013-03-20 Matt Falkenhagen <[email protected]>
+
+ Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
+ https://bugs.webkit.org/show_bug.cgi?id=112767
+
+ Reviewed by Kent Tamura.
+
+ This is part of a refactoring to move Node::disabled to HTMLFormControlElement::disabled.
+ The concept of disabled is just a form control element one.
+
+ HTMLMeterElement, HTMLOutputElement, and HTMLProgressElement never
+ have disabled() return true, so we can remove the call. In addition,
+ HTMLMeterElement and HTMLProgressElement no longer inherit from
+ HTMLFormControlElement, so we don't need to override supportsFocus.
+
+ No new tests because no behavior change.
+
+ * html/HTMLMeterElement.cpp:
+ * html/HTMLMeterElement.h:
+ * html/HTMLOutputElement.cpp:
+ (WebCore::HTMLOutputElement::supportsFocus):
+ * html/HTMLProgressElement.cpp:
+ * html/HTMLProgressElement.h:
+
2013-03-20 Jaehun Lim <[email protected]>
[css3-text] Parsing -webkit-each-line value for text-indent from css3-text
Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (146416 => 146417)
--- trunk/Source/WebCore/html/HTMLMeterElement.cpp 2013-03-21 00:08:39 UTC (rev 146416)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp 2013-03-21 00:09:32 UTC (rev 146417)
@@ -71,11 +71,6 @@
return childContext.isOnUpperEncapsulationBoundary() && HTMLElement::childShouldCreateRenderer(childContext);
}
-bool HTMLMeterElement::supportsFocus() const
-{
- return HTMLElement::supportsFocus() && !disabled();
-}
-
void HTMLMeterElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
if (name == valueAttr || name == minAttr || name == maxAttr || name == lowAttr || name == highAttr || name == optimumAttr)
Modified: trunk/Source/WebCore/html/HTMLMeterElement.h (146416 => 146417)
--- trunk/Source/WebCore/html/HTMLMeterElement.h 2013-03-21 00:08:39 UTC (rev 146416)
+++ trunk/Source/WebCore/html/HTMLMeterElement.h 2013-03-21 00:09:32 UTC (rev 146417)
@@ -71,8 +71,6 @@
virtual bool supportLabels() const OVERRIDE { return true; }
- virtual bool supportsFocus() const;
-
virtual bool recalcWillValidate() const { return false; }
virtual RenderObject* createRenderer(RenderArena*, RenderStyle*);
virtual bool childShouldCreateRenderer(const NodeRenderingContext&) const OVERRIDE;
Modified: trunk/Source/WebCore/html/HTMLOutputElement.cpp (146416 => 146417)
--- trunk/Source/WebCore/html/HTMLOutputElement.cpp 2013-03-21 00:08:39 UTC (rev 146416)
+++ trunk/Source/WebCore/html/HTMLOutputElement.cpp 2013-03-21 00:09:32 UTC (rev 146417)
@@ -59,7 +59,7 @@
bool HTMLOutputElement::supportsFocus() const
{
- return HTMLElement::supportsFocus() && !disabled();
+ return HTMLElement::supportsFocus();
}
void HTMLOutputElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
Modified: trunk/Source/WebCore/html/HTMLProgressElement.cpp (146416 => 146417)
--- trunk/Source/WebCore/html/HTMLProgressElement.cpp 2013-03-21 00:08:39 UTC (rev 146416)
+++ trunk/Source/WebCore/html/HTMLProgressElement.cpp 2013-03-21 00:09:32 UTC (rev 146417)
@@ -82,11 +82,6 @@
return static_cast<RenderProgress*>(renderObject);
}
-bool HTMLProgressElement::supportsFocus() const
-{
- return HTMLElement::supportsFocus() && !disabled();
-}
-
void HTMLProgressElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
if (name == valueAttr)
Modified: trunk/Source/WebCore/html/HTMLProgressElement.h (146416 => 146417)
--- trunk/Source/WebCore/html/HTMLProgressElement.h 2013-03-21 00:08:39 UTC (rev 146416)
+++ trunk/Source/WebCore/html/HTMLProgressElement.h 2013-03-21 00:09:32 UTC (rev 146417)
@@ -56,8 +56,6 @@
virtual bool supportLabels() const OVERRIDE { return true; }
- virtual bool supportsFocus() const;
-
virtual RenderObject* createRenderer(RenderArena*, RenderStyle*);
virtual bool childShouldCreateRenderer(const NodeRenderingContext&) const OVERRIDE;
RenderProgress* renderProgress() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
