Title: [146517] trunk/Tools
- Revision
- 146517
- Author
- [email protected]
- Date
- 2013-03-21 14:02:57 -0700 (Thu, 21 Mar 2013)
Log Message
Cleanup android media layout test code
https://bugs.webkit.org/show_bug.cgi?id=112944
Patch by Min Qin <[email protected]> on 2013-03-21
Reviewed by Adam Barth.
Chromium change: https://codereview.chromium.org/12892010/
The current android layout tests are using WebmediaPlayerInProcessAndroid class.
The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
Instead, we should switch to use content shell for layout tests.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (146516 => 146517)
--- trunk/Tools/ChangeLog 2013-03-21 21:02:34 UTC (rev 146516)
+++ trunk/Tools/ChangeLog 2013-03-21 21:02:57 UTC (rev 146517)
@@ -1,3 +1,19 @@
+2013-03-21 Min Qin <[email protected]>
+
+ Cleanup android media layout test code
+ https://bugs.webkit.org/show_bug.cgi?id=112944
+
+ Reviewed by Adam Barth.
+
+ Chromium change: https://codereview.chromium.org/12892010/
+ The current android layout tests are using WebmediaPlayerInProcessAndroid class.
+ The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
+ It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
+ Instead, we should switch to use content shell for layout tests.
+
+ * DumpRenderTree/chromium/TestShell.cpp:
+ (TestShell::resetTestController):
+
2013-03-21 Dirk Pranke <[email protected]>
[chromium] add missing project dependencies to DRT to fix Mac Valgrind
Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (146516 => 146517)
--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2013-03-21 21:02:34 UTC (rev 146516)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2013-03-21 21:02:57 UTC (rev 146517)
@@ -278,9 +278,6 @@
m_testInterfaces->resetAll();
m_devToolsTestInterfaces->resetAll();
m_webViewHost->reset();
-#if OS(ANDROID)
- webkit_support::ReleaseMediaResources();
-#endif
m_drtDevToolsAgent->reset();
if (m_drtDevToolsClient)
m_drtDevToolsClient->reset();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
