Title: [146590] trunk/Source/WebCore
Revision
146590
Author
[email protected]
Date
2013-03-22 04:58:21 -0700 (Fri, 22 Mar 2013)

Log Message

[Texmap] TextureMapperImageBuffer should not use rendering code for filters.
https://bugs.webkit.org/show_bug.cgi?id=113040

Patch by No'am Rosenthal <[email protected]> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.

Disable TextureMapperImageBuffer filters, until they can be done the right way.
This should only disrupt accelerated filters in fallback mode, which is a very rare
use case.

No new testable functionality.

* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (146589 => 146590)


--- trunk/Source/WebCore/ChangeLog	2013-03-22 11:54:23 UTC (rev 146589)
+++ trunk/Source/WebCore/ChangeLog	2013-03-22 11:58:21 UTC (rev 146590)
@@ -1,3 +1,19 @@
+2013-03-22  No'am Rosenthal  <[email protected]>
+
+        [Texmap] TextureMapperImageBuffer should not use rendering code for filters.
+        https://bugs.webkit.org/show_bug.cgi?id=113040
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Disable TextureMapperImageBuffer filters, until they can be done the right way.
+        This should only disrupt accelerated filters in fallback mode, which is a very rare
+        use case.
+
+        No new testable functionality.
+
+        * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
+        (WebCore::BitmapTextureImageBuffer::applyFilters):
+
 2013-03-22  Sergey Ryazanov  <[email protected]>
 
         Web Inspector: Report more CSS errors

Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp (146589 => 146590)


--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp	2013-03-22 11:54:23 UTC (rev 146589)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp	2013-03-22 11:58:21 UTC (rev 146590)
@@ -20,7 +20,6 @@
 #include "config.h"
 #include "TextureMapperImageBuffer.h"
 
-#include "FilterEffectRenderer.h"
 #include "GraphicsLayer.h"
 #if PLATFORM(QT)
 #include "NativeImageQt.h"
@@ -164,19 +163,8 @@
 }
 
 #if ENABLE(CSS_FILTERS)
-PassRefPtr<BitmapTexture> BitmapTextureImageBuffer::applyFilters(TextureMapper*, const BitmapTexture& contentTexture, const FilterOperations& filters)
+PassRefPtr<BitmapTexture> BitmapTextureImageBuffer::applyFilters(TextureMapper*, const BitmapTexture&, const FilterOperations&)
 {
-    RefPtr<FilterEffectRenderer> renderer = FilterEffectRenderer::create();
-    renderer->setSourceImageRect(FloatRect(FloatPoint::zero(), contentTexture.size()));
-
-    // The renderer parameter is only needed for CSS shaders and reference filters.
-    if (renderer->build(0 /*renderer */, filters)) {
-        renderer->allocateBackingStoreIfNeeded();
-        GraphicsContext* context = renderer->inputContext();
-        context->drawImageBuffer(static_cast<const BitmapTextureImageBuffer&>(contentTexture).m_image.get(), ColorSpaceDeviceRGB, IntPoint::zero());
-        renderer->apply();
-        m_image->context()->drawImageBuffer(renderer->output(), ColorSpaceDeviceRGB, renderer->outputRect());
-    }
     return this;
 }
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to