Title: [146625] trunk/Tools
Revision
146625
Author
[email protected]
Date
2013-03-22 10:03:12 -0700 (Fri, 22 Mar 2013)

Log Message

Leak bots shouldn't build
https://bugs.webkit.org/show_bug.cgi?id=112774

Reviewed by Simon Fraser.

Since leak bots use regular debug builds, there is no need to build on these bots.
Simply downloading builds will dramatically improve the cycle time of these bots.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
TestFactory instead of BuildAndTestFactory.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (146624 => 146625)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2013-03-22 16:58:59 UTC (rev 146624)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2013-03-22 17:03:12 UTC (rev 146625)
@@ -78,13 +78,13 @@
                     { "name": "sh4-linux-1", "platform": "qt-sh4"}
                   ],
 
-    "builders":   [ { "name": "Apple Lion (Leaks)", "type": "BuildAndTestLeaks", "builddir": "lion-leaks",
+    "builders":   [ { "name": "Apple Lion (Leaks)", "type": "TestLeaks", "builddir": "lion-leaks",
                       "platform": "mac-lion", "configuration": "debug", "architectures": ["x86_64"],
                       "slavenames": ["apple-macpro-3"]
                     },
                     { "name": "Apple Lion Debug (Build)", "type": "Build", "builddir": "lion-debug",
                       "platform": "mac-lion", "configuration": "debug", "architectures": ["x86_64"],
-                      "triggers": ["lion-debug-tests-wk1", "lion-debug-tests-wk2"],
+                      "triggers": ["lion-debug-tests-wk1", "lion-debug-tests-wk2", "lion-leaks"],
                       "slavenames": ["apple-xserve-2", "apple-xserve-10"]
                     },
                     { "name": "Apple Lion Release (Build)", "type": "Build", "builddir": "lion-release",
@@ -113,13 +113,13 @@
                       "platform": "mac-lion", "configuration": "release", "architectures": ["x86_64"],
                       "slavenames": ["apple-xserve-11"]
                     },
-                    { "name": "Apple MountainLion (Leaks)", "type": "BuildAndTestLeaks", "builddir": "mountainlion-leaks",
+                    { "name": "Apple MountainLion (Leaks)", "type": "TestLeaks", "builddir": "mountainlion-leaks",
                       "platform": "mac-mountainlion", "configuration": "debug", "architectures": ["x86_64"],
                       "slavenames": ["apple-mini-201"]
                     },
                     { "name": "Apple MountainLion Debug (Build)", "type": "Build", "builddir": "mountainlion-debug",
                       "platform": "mac-mountainlion", "configuration": "debug", "architectures": ["x86_64"],
-                      "triggers": ["mountainlion-debug-tests-wk1", "mountainlion-debug-tests-wk2"],
+                      "triggers": ["mountainlion-debug-tests-wk1", "mountainlion-debug-tests-wk2", "mountainlion-leaks"],
                       "slavenames": ["apple-mini-202", "apple-mini-203"]
                     },
                     { "name": "Apple MountainLion Release (Build)", "type": "Build", "builddir": "mountainlion-release",
@@ -385,6 +385,9 @@
                     { "type": "Triggerable", "name": "lion-debug-tests-wk2",
                       "builderNames": ["Apple Lion Debug WK2 (Tests)"]
                     },
+                    { "type": "Triggerable", "name": "lion-leaks",
+                      "builderNames": ["Apple Lion (Leaks)"]
+                    },
                     { "type": "Triggerable", "name": "mountainlion-release-tests-wk1",
                       "builderNames": ["Apple MountainLion Release WK1 (Tests)"]
                     },
@@ -400,6 +403,9 @@
                     { "type": "Triggerable", "name": "mountainlion-debug-tests-wk2",
                       "builderNames": ["Apple MountainLion Debug WK2 (Tests)"]
                     },
+                    { "type": "Triggerable", "name": "mountainlion-leaks",
+                      "builderNames": ["Apple MountainLion (Leaks)"]
+                    },
                     { "type": "Triggerable", "name": "win-release-tests",
                       "builderNames": ["Apple Win 7 Release (Tests)"]
                     },

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (146624 => 146625)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2013-03-22 16:58:59 UTC (rev 146624)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2013-03-22 17:03:12 UTC (rev 146625)
@@ -863,7 +863,7 @@
     CompileClass = CompileWebKit2Only
     TestClass = RunWebKit2Tests
 
-class BuildAndTestLeaksFactory(BuildAndTestFactory):
+class TestLeaksFactory(TestFactory):
     TestClass = RunWebKitLeakTests
     ExtractTestResultsClass = ExtractTestResultsAndLeaks
 

Modified: trunk/Tools/ChangeLog (146624 => 146625)


--- trunk/Tools/ChangeLog	2013-03-22 16:58:59 UTC (rev 146624)
+++ trunk/Tools/ChangeLog	2013-03-22 17:03:12 UTC (rev 146625)
@@ -1,3 +1,18 @@
+2013-03-19  Ryosuke Niwa  <[email protected]>
+
+        Leak bots shouldn't build
+        https://bugs.webkit.org/show_bug.cgi?id=112774
+
+        Reviewed by Simon Fraser.
+
+        Since leak bots use regular debug builds, there is no need to build on these bots.
+        Simply downloading builds will dramatically improve the cycle time of these bots.
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json:
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+        (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
+        TestFactory instead of BuildAndTestFactory.
+
 2013-03-22  Jocelyn Turcotte  <[email protected]>
 
         [Qt] Fix the TestWebKitAPI build
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to