Modified: trunk/Source/WebCore/ChangeLog (146792 => 146793)
--- trunk/Source/WebCore/ChangeLog 2013-03-25 18:40:48 UTC (rev 146792)
+++ trunk/Source/WebCore/ChangeLog 2013-03-25 18:43:35 UTC (rev 146793)
@@ -1,3 +1,10 @@
+2013-03-25 Roger Fong <[email protected]>
+
+ Unreviewed. Remove some suspicious looking code in an attempt to fix EWS bots.
+
+ * bindings/scripts/preprocessor.pm:
+ (applyPreprocessor):
+
2013-03-25 Martin Robinson <[email protected]>
[GTK] [gyp] Add support for building the platform directory
Modified: trunk/Source/WebCore/bindings/scripts/preprocessor.pm (146792 => 146793)
--- trunk/Source/WebCore/bindings/scripts/preprocessor.pm 2013-03-25 18:40:48 UTC (rev 146792)
+++ trunk/Source/WebCore/bindings/scripts/preprocessor.pm 2013-03-25 18:43:35 UTC (rev 146793)
@@ -64,18 +64,10 @@
my $pid = 0;
if ($Config{osname} eq "cygwin" || $Config{osname} eq 'MSWin32') {
- # This call can fail if Windows rebases cygwin, so retry a few times until it succeeds.
- for (my $tries = 0; !$pid && ($tries < 20); $tries++) {
- eval {
- # Suppress STDERR so that if we're using cl.exe, the output
- # name isn't needlessly echoed.
- use Symbol 'gensym'; my $err = gensym;
- $pid = open3(\*PP_IN, \*PP_OUT, $err, split(' ', $preprocessor), @args, @macros, $fileName);
- sleep 1;
- } or do {
- sleep 1;
- }
- };
+ # Suppress STDERR so that if we're using cl.exe, the output
+ # name isn't needlessly echoed.
+ use Symbol 'gensym'; my $err = gensym;
+ $pid = open3(\*PP_IN, \*PP_OUT, $err, split(' ', $preprocessor), @args, @macros, $fileName);
} else {
$pid = open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), @args, @macros, $fileName);
}
Modified: trunk/Tools/ChangeLog (146792 => 146793)
--- trunk/Tools/ChangeLog 2013-03-25 18:40:48 UTC (rev 146792)
+++ trunk/Tools/ChangeLog 2013-03-25 18:43:35 UTC (rev 146793)
@@ -1,3 +1,10 @@
+2013-03-25 Roger Fong <[email protected]>
+
+ Unreviewed. Enable WinEWS tests again.
+
+ * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+ (WinEWS):
+
2013-03-25 Dominik Röttsches <[email protected]>
[HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (146792 => 146793)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2013-03-25 18:40:48 UTC (rev 146792)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2013-03-25 18:43:35 UTC (rev 146793)
@@ -174,6 +174,7 @@
class WinEWS(AbstractEarlyWarningSystem):
name = "win-ews"
port_name = "win"
+ _default_run_tests = True
class AbstractChromiumEWS(AbstractEarlyWarningSystem):
port_name = "chromium"
