Title: [147161] trunk/Source/WebKit/chromium
Revision
147161
Author
[email protected]
Date
2013-03-28 14:46:53 -0700 (Thu, 28 Mar 2013)

Log Message

[Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly dispatches 'invalid' events
https://bugs.webkit.org/show_bug.cgi?id=113377

Reviewed by Dimitri Glazkov.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
We don't need to call HTMLFormElement::checkValidity here.

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (147160 => 147161)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-28 21:46:18 UTC (rev 147160)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-28 21:46:53 UTC (rev 147161)
@@ -1,3 +1,14 @@
+2013-03-28  Kent Tamura  <[email protected]>
+
+        [Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly dispatches 'invalid' events
+        https://bugs.webkit.org/show_bug.cgi?id=113377
+
+        Reviewed by Dimitri Glazkov.
+
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+        We don't need to call HTMLFormElement::checkValidity here.
+
 2013-03-28  Sheriff Bot  <[email protected]>
 
         Unreviewed.  Rolled Chromium DEPS to r191172.  Requested by

Modified: trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp (147160 => 147161)


--- trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp	2013-03-28 21:46:18 UTC (rev 147160)
+++ trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp	2013-03-28 21:46:53 UTC (rev 147161)
@@ -338,7 +338,7 @@
             }
         }
         HTMLFormElement* form = selectedFrame->selection()->currentForm();
-        if (form && form->checkValidity() && r.innerNonSharedNode()->hasTagName(HTMLNames::inputTag)) {
+        if (form && r.innerNonSharedNode()->hasTagName(HTMLNames::inputTag)) {
             HTMLInputElement* selectedElement = static_cast<HTMLInputElement*>(r.innerNonSharedNode());
             if (selectedElement) {
                 WebSearchableFormData ws = WebSearchableFormData(WebFormElement(form), WebInputElement(selectedElement));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to