Diff
Modified: trunk/LayoutTests/ChangeLog (147279 => 147280)
--- trunk/LayoutTests/ChangeLog 2013-03-30 13:08:24 UTC (rev 147279)
+++ trunk/LayoutTests/ChangeLog 2013-03-30 18:22:52 UTC (rev 147280)
@@ -1,3 +1,13 @@
+2013-03-30 Tom Sepez <[email protected]>
+
+ View-source iframes are dangerous (and not very useful).
+ https://bugs.webkit.org/show_bug.cgi?id=113345
+
+ Reviewed by Adam Barth.
+
+ * platform/chromium/TestExpectations:
+ Update expectations now that chromium excludes iframe's viewsource attribute.
+
2013-03-30 Sergey Ryazanov <[email protected]>
Layout Test inspector/console/console-css-warnings.html is failing on debug.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (147279 => 147280)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-30 13:08:24 UTC (rev 147279)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-30 18:22:52 UTC (rev 147280)
@@ -935,6 +935,17 @@
# Chromium disabled MATHML
crbug.com/22554 mathml [ Skip ]
+# Chromium disabled iframe viewsource attribute.
+fast/frames/viewsource-attribute.html [ WontFix ]
+fast/frames/viewsource-empty-attribute-value.html [ WontFix ]
+fast/frames/viewsource-linebreak.html [ WontFix ]
+fast/frames/viewsource-link-on-href-value.html [ WontFix ]
+fast/frames/viewsource-on-image-file.html [ WontFix ]
+fast/frames/viewsource-plain-text-tags.html [ WontFix ]
+fast/frames/viewsource-xml.html [ WontFix ]
+http/tests/security/view-source-no-_javascript_-url.html [ WontFix ]
+http/tests/security/view-source-no-refresh.html [ WontFix ]
+
# INPUT_TYPE_DATETIME_INCOMPLETE is disabled across Chromium until a better Android UI is worked out. See crbug.com/164561.
webkit.org/b/109272 fast/forms/datetime [ Skip ]
webkit.org/b/109272 fast/forms/datetime-multiple-fields [ Skip ]
Modified: trunk/Source/WTF/ChangeLog (147279 => 147280)
--- trunk/Source/WTF/ChangeLog 2013-03-30 13:08:24 UTC (rev 147279)
+++ trunk/Source/WTF/ChangeLog 2013-03-30 18:22:52 UTC (rev 147280)
@@ -1,3 +1,13 @@
+2013-03-30 Tom Sepez <[email protected]>
+
+ View-source iframes are dangerous (and not very useful).
+ https://bugs.webkit.org/show_bug.cgi?id=113345
+
+ Reviewed by Adam Barth.
+
+ * wtf/FeatureDefines.h:
+ Default definition of ENABLE_VIEWSOURCE_ATTRIBUTE is enabled.
+
2013-03-27 Patrick Gansterer <[email protected]>
Set WTF_ARM_ARCH_VERSION to correct value when used with MSVC
Modified: trunk/Source/WTF/wtf/FeatureDefines.h (147279 => 147280)
--- trunk/Source/WTF/wtf/FeatureDefines.h 2013-03-30 13:08:24 UTC (rev 147279)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2013-03-30 18:22:52 UTC (rev 147280)
@@ -843,6 +843,10 @@
#define ENABLE_VIEWPORT 0
#endif
+#if !defined(ENABLE_VIEWSOURCE_ATTRIBUTE)
+#define ENABLE_VIEWSOURCE_ATTRIBUTE 1
+#endif
+
#if !defined(ENABLE_VIEW_MODE_CSS_MEDIA)
#define ENABLE_VIEW_MODE_CSS_MEDIA 1
#endif
Modified: trunk/Source/WebCore/ChangeLog (147279 => 147280)
--- trunk/Source/WebCore/ChangeLog 2013-03-30 13:08:24 UTC (rev 147279)
+++ trunk/Source/WebCore/ChangeLog 2013-03-30 18:22:52 UTC (rev 147280)
@@ -1,3 +1,14 @@
+2013-03-30 Tom Sepez <[email protected]>
+
+ View-source iframes are dangerous (and not very useful).
+ https://bugs.webkit.org/show_bug.cgi?id=113345
+
+ Reviewed by Adam Barth.
+
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseAttribute):
+ Conditionalize viewsource attribute on ENABLE(VIEWSOURCE_ATTRIBUTE).
+
2013-03-30 Philippe Normand <[email protected]>
[GTK] Should use GStreamer codec installation infrastructure
Modified: trunk/Source/WebCore/html/HTMLFrameElementBase.cpp (147279 => 147280)
--- trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2013-03-30 13:08:24 UTC (rev 147279)
+++ trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2013-03-30 18:22:52 UTC (rev 147280)
@@ -118,10 +118,12 @@
else if (equalIgnoringCase(value, "no"))
m_scrolling = ScrollbarAlwaysOff;
// FIXME: If we are already attached, this has no effect.
+#if ENABLE(VIEWSOURCE_ATTRIBUTE)
} else if (name == viewsourceAttr) {
m_viewSource = !value.isNull();
if (contentFrame())
contentFrame()->setInViewSourceMode(viewSourceMode());
+#endif
} else if (name == onbeforeloadAttr)
setAttributeEventListener(eventNames().beforeloadEvent, createAttributeEventListener(this, name, value));
else if (name == onbeforeunloadAttr) {
Modified: trunk/Source/WebKit/chromium/ChangeLog (147279 => 147280)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-30 13:08:24 UTC (rev 147279)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-30 18:22:52 UTC (rev 147280)
@@ -1,3 +1,13 @@
+2013-03-30 Tom Sepez <[email protected]>
+
+ View-source iframes are dangerous (and not very useful).
+ https://bugs.webkit.org/show_bug.cgi?id=113345
+
+ Reviewed by Adam Barth.
+
+ * features.gypi:
+ Disable VIEWSOURCE_ATTRIBUTE for chromium.
+
2013-03-30 Alexei Filippov <[email protected]>
Web Inspector: Fonts refactoring
Modified: trunk/Source/WebKit/chromium/features.gypi (147279 => 147280)
--- trunk/Source/WebKit/chromium/features.gypi 2013-03-30 13:08:24 UTC (rev 147279)
+++ trunk/Source/WebKit/chromium/features.gypi 2013-03-30 18:22:52 UTC (rev 147280)
@@ -132,6 +132,7 @@
'ENABLE_VIDEO=1',
'ENABLE_VIDEO_TRACK=1',
'ENABLE_VIEWPORT=1',
+ 'ENABLE_VIEWSOURCE_ATTRIBUTE=0',
'ENABLE_VIEW_MODE_CSS_MEDIA=1',
'ENABLE_WEBGL=1',
'ENABLE_WEB_SOCKETS=1',
