Title: [147425] trunk/Source/WebCore
Revision
147425
Author
[email protected]
Date
2013-04-02 06:46:45 -0700 (Tue, 02 Apr 2013)

Log Message

Web Inspector: ignore minimum record duration filter in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=113705

Reviewed by Pavel Feldman.

* inspector/front-end/TimelineOverviewPane.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._durationFilterChanged):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (147424 => 147425)


--- trunk/Source/WebCore/ChangeLog	2013-04-02 13:45:45 UTC (rev 147424)
+++ trunk/Source/WebCore/ChangeLog	2013-04-02 13:46:45 UTC (rev 147425)
@@ -1,3 +1,14 @@
+2013-04-02  Andrey Kosyakov  <[email protected]>
+
+        Web Inspector: ignore minimum record duration filter in Timeline overview
+        https://bugs.webkit.org/show_bug.cgi?id=113705
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/TimelineOverviewPane.js:
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._durationFilterChanged):
+
 2013-03-29  Andrey Kosyakov  <[email protected]>
 
         Web Inspector: display the number of dirty render objects in Layout timeline event

Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (147424 => 147425)


--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js	2013-04-02 13:45:45 UTC (rev 147424)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js	2013-04-02 13:46:45 UTC (rev 147425)
@@ -315,14 +315,6 @@
         this._ignoreWindowChangedEvent = false;
     },
 
-    /**
-     * @param {number} value
-     */
-    setMinimumRecordDuration: function(value)
-    {
-        this._eventOverview.setMinimumRecordDuration(value);
-    },
-
     _scheduleRefresh: function()
     {
         if (this._refreshTimeout)
@@ -535,7 +527,6 @@
     WebInspector.TimelineOverviewBase.call(this, model);
 
     this._context = this._canvas.getContext("2d");
-    this._minimumRecordDuration = 0;
 
     this._fillStyles = {};
     var categories = WebInspector.TimelinePresentationModel.categories();
@@ -578,8 +569,6 @@
 
         function appendRecord(record)
         {
-            if (!!this._minimumRecordDuration && (WebInspector.TimelineModel.durationInSeconds(record) < this._minimumRecordDuration))
-                return;
             if (record.type === WebInspector.TimelineModel.RecordType.BeginFrame)
                 return;
             var recordStart = Math.floor((WebInspector.TimelineModel.startTimeInSeconds(record) - timeOffset) * scale);
@@ -606,15 +595,6 @@
         }
     },
 
-    /**
-     * @param {number} value
-     */
-    setMinimumRecordDuration: function(value)
-    {
-        this._minimumRecordDuration = value;
-        this.update();
-    },
-
     _renderBar: function(begin, end, category)
     {
         var x = begin + 0.5;

Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (147424 => 147425)


--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2013-04-02 13:45:45 UTC (rev 147424)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2013-04-02 13:46:45 UTC (rev 147425)
@@ -602,7 +602,6 @@
         var option = this._durationFilterSelector.selectedOption();
         var minimumRecordDuration = +option._durationMs / 1000.0;
         this._durationFilter.setMinimumRecordDuration(minimumRecordDuration);
-        this._overviewPane.setMinimumRecordDuration(minimumRecordDuration);
         this._durationFilterSelector.element.title = option.title;
         this._invalidateAndScheduleRefresh(true, true);
     },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to