Title: [147433] trunk/Source/WebCore
Revision
147433
Author
[email protected]
Date
2013-04-02 07:58:05 -0700 (Tue, 02 Apr 2013)

Log Message

Web Inspector: source location gets frozen after inspector reload
https://bugs.webkit.org/show_bug.cgi?id=113776

Patch by Andrey Lushnikov <[email protected]> on 2013-04-02
Reviewed by Pavel Feldman.

Put statusBarText item in its own container and update its contents in
ScriptsPanel._updateScriptViewStatusBarItems in similar way it's done
for statusBarItems.

No new tests.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.statusBarText):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (147432 => 147433)


--- trunk/Source/WebCore/ChangeLog	2013-04-02 14:47:37 UTC (rev 147432)
+++ trunk/Source/WebCore/ChangeLog	2013-04-02 14:58:05 UTC (rev 147433)
@@ -1,3 +1,21 @@
+2013-04-02  Andrey Lushnikov  <[email protected]>
+
+        Web Inspector: source location gets frozen after inspector reload
+        https://bugs.webkit.org/show_bug.cgi?id=113776
+
+        Reviewed by Pavel Feldman.
+
+        Put statusBarText item in its own container and update its contents in
+        ScriptsPanel._updateScriptViewStatusBarItems in similar way it's done
+        for statusBarItems.
+
+        No new tests.
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel):
+        (WebInspector.ScriptsPanel.prototype.statusBarText):
+        (WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
+
 2013-04-02  Jesus Sanchez-Palencia  <[email protected]>
 
         Remove unneeded cpp file from CMake build. Rubber-stamp by Alexis Menard.

Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (147432 => 147433)


--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2013-04-02 14:47:37 UTC (rev 147432)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2013-04-02 14:58:05 UTC (rev 147433)
@@ -147,6 +147,9 @@
     this._scriptViewStatusBarItemsContainer = document.createElement("div");
     this._scriptViewStatusBarItemsContainer.style.display = "inline-block";
 
+    this._scriptViewStatusBarTextContainer = document.createElement("div");
+    this._scriptViewStatusBarTextContainer.style.display = "inline-block";
+
     this._installDebuggerSidebarController();
 
     WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
@@ -194,8 +197,7 @@
      */
     statusBarText: function()
     {
-        var sourceFrame = this.visibleView;
-        return sourceFrame ? sourceFrame.statusBarText() : null;
+        return this._scriptViewStatusBarTextContainer;
     },
 
     defaultFocusedElement: function()
@@ -369,12 +371,16 @@
     _updateScriptViewStatusBarItems: function()
     {
         this._scriptViewStatusBarItemsContainer.removeChildren();
+        this._scriptViewStatusBarTextContainer.removeChildren();
 
         var sourceFrame = this.visibleView;
         if (sourceFrame) {
             var statusBarItems = sourceFrame.statusBarItems() || [];
             for (var i = 0; i < statusBarItems.length; ++i)
                 this._scriptViewStatusBarItemsContainer.appendChild(statusBarItems[i]);
+            var statusBarText = sourceFrame.statusBarText();
+            if (statusBarText)
+                this._scriptViewStatusBarTextContainer.appendChild(statusBarText);
         }
     },
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to