Title: [147453] trunk
- Revision
- 147453
- Author
- [email protected]
- Date
- 2013-04-02 10:50:59 -0700 (Tue, 02 Apr 2013)
Log Message
When computing the percentage of the logical height, use the logical top and bottom
https://bugs.webkit.org/show_bug.cgi?id=113761
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
LayoutTests:
* fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
* fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (147452 => 147453)
--- trunk/LayoutTests/ChangeLog 2013-04-02 17:50:14 UTC (rev 147452)
+++ trunk/LayoutTests/ChangeLog 2013-04-02 17:50:59 UTC (rev 147453)
@@ -1,3 +1,13 @@
+2013-04-02 Jochen Eisinger <[email protected]>
+
+ When computing the percentage of the logical height, use the logical top and bottom
+ https://bugs.webkit.org/show_bug.cgi?id=113761
+
+ Reviewed by Ojan Vafai.
+
+ * fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
+ * fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
+
2013-04-02 Nate Chapin <[email protected]>
Unreviewed, rolling out r147402.
Modified: trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt (147452 => 147453)
--- trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt 2013-04-02 17:50:14 UTC (rev 147452)
+++ trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt 2013-04-02 17:50:59 UTC (rev 147453)
@@ -6,3 +6,4 @@
PASS
PASS
PASS
+PASS
Modified: trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes.html (147452 => 147453)
--- trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes.html 2013-04-02 17:50:14 UTC (rev 147452)
+++ trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes.html 2013-04-02 17:50:59 UTC (rev 147453)
@@ -55,4 +55,8 @@
<div class="item vertical-rl" style="width: 100%; height: 100%;" data-expected-height=584 data-expected-width=0></div>
</div>
+<div class="container vertical-rl" style="position: absolute; left: 0px; right: 0px; width: auto">
+ <div class="item vertical-rl" style="width: 100%" data-expected-height=100></div>
+</div>
+
</body>
Modified: trunk/Source/WebCore/ChangeLog (147452 => 147453)
--- trunk/Source/WebCore/ChangeLog 2013-04-02 17:50:14 UTC (rev 147452)
+++ trunk/Source/WebCore/ChangeLog 2013-04-02 17:50:59 UTC (rev 147453)
@@ -1,3 +1,15 @@
+2013-04-02 Jochen Eisinger <[email protected]>
+
+ When computing the percentage of the logical height, use the logical top and bottom
+ https://bugs.webkit.org/show_bug.cgi?id=113761
+
+ Reviewed by Ojan Vafai.
+
+ Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computePercentageLogicalHeight):
+
2013-04-02 Andrey Lushnikov <[email protected]>
Web Inspector: [CodeMirror] do not show cursor in read-only mode
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (147452 => 147453)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2013-04-02 17:50:14 UTC (rev 147452)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2013-04-02 17:50:59 UTC (rev 147453)
@@ -2614,9 +2614,7 @@
// A positioned element that specified both top/bottom or that specifies height should be treated as though it has a height
// explicitly specified that can be used for any percentage computations.
- // FIXME: We can't just check top/bottom here.
- // https://bugs.webkit.org/show_bug.cgi?id=46500
- bool isOutOfFlowPositionedWithSpecifiedHeight = cb->isOutOfFlowPositioned() && (!cbstyle->logicalHeight().isAuto() || (!cbstyle->top().isAuto() && !cbstyle->bottom().isAuto()));
+ bool isOutOfFlowPositionedWithSpecifiedHeight = cb->isOutOfFlowPositioned() && (!cbstyle->logicalHeight().isAuto() || (!cbstyle->logicalTop().isAuto() && !cbstyle->logicalBottom().isAuto()));
bool includeBorderPadding = isTable();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
