Title: [147469] trunk/Source/WebCore
Revision
147469
Author
[email protected]
Date
2013-04-02 11:20:14 -0700 (Tue, 02 Apr 2013)

Log Message

Web Inspector: Avoid using style.display="inline-block"
https://bugs.webkit.org/show_bug.cgi?id=113802

Patch by Andrey Lushnikov <[email protected]> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests.

- Create class "inline-block" which will set "display: inline-block"
style.
- Use this class with DIV elements to get "inline-block" element.

* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/inspector.css:
(.inline-block):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (147468 => 147469)


--- trunk/Source/WebCore/ChangeLog	2013-04-02 18:18:48 UTC (rev 147468)
+++ trunk/Source/WebCore/ChangeLog	2013-04-02 18:20:14 UTC (rev 147469)
@@ -1,3 +1,24 @@
+2013-04-02  Andrey Lushnikov  <[email protected]>
+
+        Web Inspector: Avoid using style.display="inline-block"
+        https://bugs.webkit.org/show_bug.cgi?id=113802
+
+        Reviewed by Pavel Feldman.
+
+        No new tests.
+
+        - Create class "inline-block" which will set "display: inline-block"
+        style.
+        - Use this class with DIV elements to get "inline-block" element.
+
+        * inspector/front-end/ObjectPopoverHelper.js:
+        (WebInspector.ObjectPopoverHelper.prototype.):
+        (WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel):
+        * inspector/front-end/inspector.css:
+        (.inline-block):
+
 2013-04-02  Andrey Kosyakov  <[email protected]>
 
         Web Inspector: [Timeline] warning markers are not propagated to coalesced records

Modified: trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js (147468 => 147469)


--- trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js	2013-04-02 18:18:48 UTC (rev 147468)
+++ trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js	2013-04-02 18:20:14 UTC (rev 147469)
@@ -83,7 +83,7 @@
                             return;
                         }
                         var container = document.createElement("div");
-                        container.style.display = "inline-block";
+                        container.className = "inline-block";
 
                         var title = container.createChild("div", "function-popover-title source-code");
                         var functionName = title.createChild("span", "function-name");

Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (147468 => 147469)


--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2013-04-02 18:18:48 UTC (rev 147468)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2013-04-02 18:20:14 UTC (rev 147469)
@@ -145,10 +145,10 @@
     this._toggleFormatSourceButton.addEventListener("click", this._toggleFormatSource, this);
 
     this._scriptViewStatusBarItemsContainer = document.createElement("div");
-    this._scriptViewStatusBarItemsContainer.style.display = "inline-block";
+    this._scriptViewStatusBarItemsContainer.className = "inline-block";
 
     this._scriptViewStatusBarTextContainer = document.createElement("div");
-    this._scriptViewStatusBarTextContainer.style.display = "inline-block";
+    this._scriptViewStatusBarTextContainer.className = "inline-block";
 
     this._installDebuggerSidebarController();
 

Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (147468 => 147469)


--- trunk/Source/WebCore/inspector/front-end/inspector.css	2013-04-02 18:18:48 UTC (rev 147468)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css	2013-04-02 18:20:14 UTC (rev 147469)
@@ -39,6 +39,10 @@
     bottom: 0;
 }
 
+.inline-block {
+    display: inline-block;
+}
+
 .hidden {
     display: none;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to