Title: [147486] trunk/Source/WebCore
- Revision
- 147486
- Author
- [email protected]
- Date
- 2013-04-02 12:53:35 -0700 (Tue, 02 Apr 2013)
Log Message
Fix css style for CC button on android
https://bugs.webkit.org/show_bug.cgi?id=113815
Patch by Min Qin <[email protected]> on 2013-04-02
Reviewed by Adam Barth.
The default CC button size is 16px as defined in mediaControls.css. Android should use 35px.
This change fixed that problem.
Also fixed a problem that r142947 does not change the display of fullscreen button to -webkit-flex
Android does not run media layout tests currently. Will fix the test expectations when layout tests are run in content shell.
* css/mediaControlsChromiumAndroid.css:
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (147485 => 147486)
--- trunk/Source/WebCore/ChangeLog 2013-04-02 19:52:22 UTC (rev 147485)
+++ trunk/Source/WebCore/ChangeLog 2013-04-02 19:53:35 UTC (rev 147486)
@@ -1,3 +1,19 @@
+2013-04-02 Min Qin <[email protected]>
+
+ Fix css style for CC button on android
+ https://bugs.webkit.org/show_bug.cgi?id=113815
+
+ Reviewed by Adam Barth.
+
+ The default CC button size is 16px as defined in mediaControls.css. Android should use 35px.
+ This change fixed that problem.
+ Also fixed a problem that r142947 does not change the display of fullscreen button to -webkit-flex
+ Android does not run media layout tests currently. Will fix the test expectations when layout tests are run in content shell.
+
+ * css/mediaControlsChromiumAndroid.css:
+ (video::-webkit-media-controls-fullscreen-button):
+ (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
+
2013-04-02 Alexey Proskuryakov <[email protected]>
[Mac] Remove WKCreateNSURLConnectionDelegateProxy
Modified: trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css (147485 => 147486)
--- trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css 2013-04-02 19:52:22 UTC (rev 147485)
+++ trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css 2013-04-02 19:53:35 UTC (rev 147486)
@@ -161,7 +161,7 @@
video::-webkit-media-controls-fullscreen-button {
-webkit-appearance: media-enter-fullscreen-button;
- display: inline;
+ display: -webkit-flex;
border: none;
box-sizing: border-box;
width: 35px;
@@ -172,6 +172,19 @@
padding: 0;
}
+audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button {
+ -webkit-appearance: media-toggle-closed-captions-button;
+ display: -webkit-flex;
+ border: none;
+ box-sizing: border-box;
+ width: 35px;
+ height: 35px;
+ line-height: 35px;
+ margin-left: -5px;
+ margin-right: 9px;
+ padding: 0;
+}
+
input[type="range"]::-webkit-media-slider-container {
display: -webkit-flex;
-webkit-align-items: center;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
