Title: [147640] trunk/Source
Revision
147640
Author
[email protected]
Date
2013-04-04 09:40:41 -0700 (Thu, 04 Apr 2013)

Log Message

Fix the build with GCC 4.8
https://bugs.webkit.org/show_bug.cgi?id=113147

Reviewed by Allan Sandfeld Jensen.

Source/_javascript_Core:

Initialize JSObject* exception to suppress warnings that make
the build fail because of -Werror=maybe-uninitialized.

* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

Source/WTF:

Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
since dummy typedefs are commonly used in the codebase.

* wtf/Compiler.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (147639 => 147640)


--- trunk/Source/_javascript_Core/ChangeLog	2013-04-04 16:37:08 UTC (rev 147639)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-04-04 16:40:41 UTC (rev 147640)
@@ -1,3 +1,17 @@
+2013-04-04  Andras Becsi  <[email protected]>
+
+        Fix the build with GCC 4.8
+        https://bugs.webkit.org/show_bug.cgi?id=113147
+
+        Reviewed by Allan Sandfeld Jensen.
+
+        Initialize JSObject* exception to suppress warnings that make
+        the build fail because of -Werror=maybe-uninitialized.
+
+        * runtime/Executable.cpp:
+        (JSC::FunctionExecutable::compileForCallInternal):
+        (JSC::FunctionExecutable::compileForConstructInternal):
+
 2013-04-02  Mark Hahnenberg  <[email protected]>
 
         get_by_pname can become confused when iterating over objects with static properties

Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (147639 => 147640)


--- trunk/Source/_javascript_Core/runtime/Executable.cpp	2013-04-04 16:37:08 UTC (rev 147639)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp	2013-04-04 16:40:41 UTC (rev 147640)
@@ -523,7 +523,7 @@
     UNUSED_PARAM(bytecodeIndex);
 #endif
     ASSERT((jitType == JITCode::bottomTierJIT()) == !m_codeBlockForCall);
-    JSObject* exception;
+    JSObject* exception = 0;
     OwnPtr<FunctionCodeBlock> newCodeBlock = produceCodeBlockFor(scope, CodeForCall, exception);
     if (!newCodeBlock)
         return exception;
@@ -559,7 +559,7 @@
 #endif
     
     ASSERT((jitType == JITCode::bottomTierJIT()) == !m_codeBlockForConstruct);
-    JSObject* exception;
+    JSObject* exception = 0;
     OwnPtr<FunctionCodeBlock> newCodeBlock = produceCodeBlockFor(scope, CodeForConstruct, exception);
     if (!newCodeBlock)
         return exception;

Modified: trunk/Source/WTF/ChangeLog (147639 => 147640)


--- trunk/Source/WTF/ChangeLog	2013-04-04 16:37:08 UTC (rev 147639)
+++ trunk/Source/WTF/ChangeLog	2013-04-04 16:40:41 UTC (rev 147640)
@@ -1,3 +1,15 @@
+2013-04-04  Andras Becsi  <[email protected]>
+
+        Fix the build with GCC 4.8
+        https://bugs.webkit.org/show_bug.cgi?id=113147
+
+        Reviewed by Allan Sandfeld Jensen.
+
+        Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
+        since dummy typedefs are commonly used in the codebase.
+
+        * wtf/Compiler.h:
+
 2013-04-03  Pratik Solanki  <[email protected]>
 
         Enable HAVE_MADV_FREE_REUSE on iOS

Modified: trunk/Source/WTF/wtf/Compiler.h (147639 => 147640)


--- trunk/Source/WTF/wtf/Compiler.h	2013-04-04 16:37:08 UTC (rev 147639)
+++ trunk/Source/WTF/wtf/Compiler.h	2013-04-04 16:40:41 UTC (rev 147640)
@@ -123,6 +123,9 @@
 
 /* Specific compiler features */
 #if COMPILER(GCC) && !COMPILER(CLANG)
+#if GCC_VERSION_AT_LEAST(4, 8, 0)
+#pragma GCC diagnostic ignored "-Wunused-local-typedefs"
+#endif
 #if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 201112L
 /* C11 support */
 #define WTF_COMPILER_SUPPORTS_C_STATIC_ASSERT 1
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to