Title: [147664] trunk/Source/WebCore
- Revision
- 147664
- Author
- [email protected]
- Date
- 2013-04-04 12:58:45 -0700 (Thu, 04 Apr 2013)
Log Message
REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
https://bugs.webkit.org/show_bug.cgi?id=113947
<rdar://problem/13579024>
Reviewed by Anders Carlsson.
Reset the FrameView size to the minimum auto-sizing size
before performing auto-sizing. We were already resetting the height,
but not the width, instead using the FrameView's current width.
This means that changing the minimum width without also manually
resizing the FrameView will never see the width change.
Auto-sizing tests are not working on Mac yet.
* page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (147663 => 147664)
--- trunk/Source/WebCore/ChangeLog 2013-04-04 19:26:55 UTC (rev 147663)
+++ trunk/Source/WebCore/ChangeLog 2013-04-04 19:58:45 UTC (rev 147664)
@@ -1,3 +1,23 @@
+2013-04-04 Tim Horton <[email protected]>
+
+ REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
+ https://bugs.webkit.org/show_bug.cgi?id=113947
+ <rdar://problem/13579024>
+
+ Reviewed by Anders Carlsson.
+
+ Reset the FrameView size to the minimum auto-sizing size
+ before performing auto-sizing. We were already resetting the height,
+ but not the width, instead using the FrameView's current width.
+
+ This means that changing the minimum width without also manually
+ resizing the FrameView will never see the width change.
+
+ Auto-sizing tests are not working on Mac yet.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::autoSizeIfEnabled):
+
2013-04-04 Martin Robinson <[email protected]>
[GTK] Remove the gyp build
Modified: trunk/Source/WebCore/page/FrameView.cpp (147663 => 147664)
--- trunk/Source/WebCore/page/FrameView.cpp 2013-04-04 19:26:55 UTC (rev 147663)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-04-04 19:58:45 UTC (rev 147664)
@@ -2778,8 +2778,8 @@
if (!documentView || !documentElement)
return;
- // Start from the minimum height and allow it to grow.
- resize(frameRect().width(), m_minAutoSize.height());
+ // Start from the minimum size and allow it to grow.
+ resize(m_minAutoSize.width(), m_minAutoSize.height());
IntSize size = frameRect().size();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
