Title: [147667] trunk
- Revision
- 147667
- Author
- [email protected]
- Date
- 2013-04-04 13:52:51 -0700 (Thu, 04 Apr 2013)
Log Message
Unreviewed, rolling out r147662.
http://trac.webkit.org/changeset/147662
https://bugs.webkit.org/show_bug.cgi?id=113955
The change r147662 breaks fast/regions/fixed-pos-elem-in-
region.html (Requested by benjaminp on #webkit).
Patch by Sheriff Bot <[email protected]> on 2013-04-04
Source/WebCore:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
* fast/inline/inline-with-empty-inline-children-expected.txt:
* fast/inline/inline-with-empty-inline-children.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (147666 => 147667)
--- trunk/LayoutTests/ChangeLog 2013-04-04 20:46:43 UTC (rev 147666)
+++ trunk/LayoutTests/ChangeLog 2013-04-04 20:52:51 UTC (rev 147667)
@@ -1,3 +1,15 @@
+2013-04-04 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r147662.
+ http://trac.webkit.org/changeset/147662
+ https://bugs.webkit.org/show_bug.cgi?id=113955
+
+ The change r147662 breaks fast/regions/fixed-pos-elem-in-
+ region.html (Requested by benjaminp on #webkit).
+
+ * fast/inline/inline-with-empty-inline-children-expected.txt:
+ * fast/inline/inline-with-empty-inline-children.html:
+
2013-04-04 Roger Fong <[email protected]>
Unreviewed. AppleWin port gardening.
Modified: trunk/LayoutTests/fast/inline/inline-with-empty-inline-children-expected.txt (147666 => 147667)
--- trunk/LayoutTests/fast/inline/inline-with-empty-inline-children-expected.txt 2013-04-04 20:46:43 UTC (rev 147666)
+++ trunk/LayoutTests/fast/inline/inline-with-empty-inline-children-expected.txt 2013-04-04 20:52:51 UTC (rev 147667)
@@ -1,4 +1,4 @@
-https://bugs.webkit.org/show_bug.cgi?id=95772: There should be seven green bars below with a PASS in each.
+https://bugs.webkit.org/show_bug.cgi?id=95772: There should be six green bars below with a PASS in each.
PASS
PASS
@@ -6,6 +6,4 @@
PASS
PASS
PASS
-Words
-PASS
Modified: trunk/LayoutTests/fast/inline/inline-with-empty-inline-children.html (147666 => 147667)
--- trunk/LayoutTests/fast/inline/inline-with-empty-inline-children.html 2013-04-04 20:46:43 UTC (rev 147666)
+++ trunk/LayoutTests/fast/inline/inline-with-empty-inline-children.html 2013-04-04 20:52:51 UTC (rev 147667)
@@ -4,39 +4,34 @@
<style>
.block { display: block; background: green; }
.inline { display: inline; margin-left: 40px; font: 30px/1 Ahem;}
- .white-span { width: 50%; background: white; }
+ span { width: 50%; background: white; }
.absolute { position: absolute; }
.float { float: left; }
- .inline-span { display: inline-block; }
</style>
<script src=""
</head>
<body>
- <p> https://bugs.webkit.org/show_bug.cgi?id=95772: There should be seven green bars below with a PASS in each. </p>
+ <p> https://bugs.webkit.org/show_bug.cgi?id=95772: There should be six green bars below with a PASS in each. </p>
<div class="block">
- <div class="inline" data-expected-height="30"> <span class="absolute white-span"></span> <span class="absolute white-span"></span> </div>
+ <div class="inline" data-expected-height="30"> <span class="absolute"></span> <span class="absolute"></span> </div>
</div>
<div class="block">
- <div class="inline" data-expected-height="30"><span class="absolute white-span"></span><span class="absolute"></span></div>
+ <div class="inline" data-expected-height="30"><span class="absolute"></span><span class="absolute"></span></div>
</div>
<div class="block">
- <div class="inline" data-expected-height="30"><span class="float white-span"></span><span class="float white-span"></span></div>
+ <div class="inline" data-expected-height="30"><span class="float"></span><span class="float"></span></div>
</div>
<div class="block">
- <div class="inline" data-expected-height="30"> <span class="float white-span"></span> <span class="float white-span"></span></div>
+ <div class="inline" data-expected-height="30"> <span class="float"></span> <span class="float"></span></div>
</div>
<div class="block">
- <div class="inline" data-expected-height="30"><span class="white-span"></span><span class="white-span"></span></div>
+ <div class="inline" data-expected-height="30"><span></span><span></span></div>
</div>
<div class="block">
- <div class="inline" data-expected-height="30"> <span class="white-span"></span> <span class="white-span"></span></div>
+ <div class="inline" data-expected-height="30"> <span></span> <span></span></div>
</div>
- <div class="block">
- <span class="inline-span" data-expected-height="30"><div class="inline"> <div class="float"> Words </div></div></span>
- </div>
<script>
checkLayout('body > div > div')
- checkLayout('body > div > span')
</script>
</body>
</html>
Modified: trunk/Source/WebCore/ChangeLog (147666 => 147667)
--- trunk/Source/WebCore/ChangeLog 2013-04-04 20:46:43 UTC (rev 147666)
+++ trunk/Source/WebCore/ChangeLog 2013-04-04 20:52:51 UTC (rev 147667)
@@ -1,3 +1,15 @@
+2013-04-04 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r147662.
+ http://trac.webkit.org/changeset/147662
+ https://bugs.webkit.org/show_bug.cgi?id=113955
+
+ The change r147662 breaks fast/regions/fixed-pos-elem-in-
+ region.html (Requested by benjaminp on #webkit).
+
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::inlineLogicalWidth):
+
2013-04-04 Tim Horton <[email protected]>
REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (147666 => 147667)
--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2013-04-04 20:46:43 UTC (rev 147666)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2013-04-04 20:52:51 UTC (rev 147667)
@@ -326,8 +326,7 @@
unsigned lineDepth = 1;
LayoutUnit extraWidth = 0;
RenderObject* parent = child->parent();
- // Empty inline parents have added their inline border, padding and margin to the line already.
- while (parent->isRenderInline() && !isEmptyInline(parent) && lineDepth++ < cMaxLineDepth) {
+ while (parent->isRenderInline() && lineDepth++ < cMaxLineDepth) {
RenderInline* parentAsRenderInline = toRenderInline(parent);
if (!isEmptyInline(parentAsRenderInline)) {
if (start && shouldAddBorderPaddingMargin(child->previousSibling(), start))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
