Title: [147695] trunk/Tools
Revision
147695
Author
[email protected]
Date
2013-04-04 19:35:53 -0700 (Thu, 04 Apr 2013)

Log Message

Fix setup-commit-queue and temporarily disable testing on commit-queue
https://bugs.webkit.org/show_bug.cgi?id=113979

Reviewed by Benjamin Poulain.

Use [email protected] instead of [email protected] in commit-queue,
and temporarily disable tests in commit-queue as we don't have enough resources at the moment.

* EWSTools/setup-commit-queue.sh:
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (147694 => 147695)


--- trunk/Tools/ChangeLog	2013-04-05 01:29:57 UTC (rev 147694)
+++ trunk/Tools/ChangeLog	2013-04-05 02:35:53 UTC (rev 147695)
@@ -1,3 +1,17 @@
+2013-04-04  Ryosuke Niwa  <[email protected]>
+
+        Fix setup-commit-queue and temporarily disable testing on commit-queue
+        https://bugs.webkit.org/show_bug.cgi?id=113979
+
+        Reviewed by Benjamin Poulain.
+
+        Use [email protected] instead of [email protected] in commit-queue,
+        and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
+
+        * EWSTools/setup-commit-queue.sh:
+        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
+        (CommitQueueTask.run):
+
 2013-04-04  Dirk Pranke  <[email protected]>
 
         temporarily make flakiness dashboard work again webkit.org bots

Modified: trunk/Tools/EWSTools/setup-commit-queue.sh (147694 => 147695)


--- trunk/Tools/EWSTools/setup-commit-queue.sh	2013-04-05 01:29:57 UTC (rev 147694)
+++ trunk/Tools/EWSTools/setup-commit-queue.sh	2013-04-05 02:35:53 UTC (rev 147695)
@@ -25,17 +25,11 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-if [[ $# -ne 1 ]];then
-echo "Usage: setup-commit-queue.sh BOT_NUMBER"
-exit 1
-fi
-
 CWD="$(pwd)"
 cd "$(dirname "$0")"
 
 QUEUE_TYPE=commit-queue
-BOT_ID=webkit-cq-$1
[email protected]
[email protected]
 read -s -p "Bugzilla Password: " BUGZILLA_PASSWORD && echo
 [email protected]
 read -s -p "Subversion Password: " SVN_PASSWORD && echo

Modified: trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py (147694 => 147695)


--- trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py	2013-04-05 01:29:57 UTC (rev 147694)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py	2013-04-05 02:35:53 UTC (rev 147695)
@@ -82,8 +82,9 @@
                 if not self._build_without_patch():
                     return False
                 return self.report_failure()
-            if not self._did_pass_tests_recently():
-                return False
+            # FIXME: We temporarily disable tests on commit queue as we don't have enough machine resources.
+            # if not self._did_pass_tests_recently():
+            #    return False
         # Make sure the patch is still valid before landing (e.g., make sure
         # no one has set commit-queue- since we started working on the patch.)
         if not self.validate():
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to