Title: [147721] trunk/Source/WebCore
Revision
147721
Author
[email protected]
Date
2013-04-05 01:02:32 -0700 (Fri, 05 Apr 2013)

Log Message

Remove Chromium code from WebCore/editing
https://bugs.webkit.org/show_bug.cgi?id=114008

Reviewed by Benjamin Poulain.

Removed.

* editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
* editing/FrameSelection.h:
(WebCore):
* editing/chromium: Removed.
* editing/chromium/EditorChromium.cpp: Removed.
* editing/chromium/FrameSelectionChromium.cpp: Removed.

Modified Paths

Removed Paths

  • trunk/Source/WebCore/editing/chromium/

Diff

Modified: trunk/Source/WebCore/ChangeLog (147720 => 147721)


--- trunk/Source/WebCore/ChangeLog	2013-04-05 07:55:23 UTC (rev 147720)
+++ trunk/Source/WebCore/ChangeLog	2013-04-05 08:02:32 UTC (rev 147721)
@@ -1,3 +1,20 @@
+2013-04-05  Ryosuke Niwa  <[email protected]>
+
+        Remove Chromium code from WebCore/editing
+        https://bugs.webkit.org/show_bug.cgi?id=114008
+
+        Reviewed by Benjamin Poulain.
+
+        Removed.
+
+        * editing/EditingBehavior.h:
+        (WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
+        * editing/FrameSelection.h:
+        (WebCore):
+        * editing/chromium: Removed.
+        * editing/chromium/EditorChromium.cpp: Removed.
+        * editing/chromium/FrameSelectionChromium.cpp: Removed.
+
 2013-04-05  Benjamin Poulain  <[email protected]>
 
         Remove the chromium code from the filesystem module

Modified: trunk/Source/WebCore/editing/EditingBehavior.h (147720 => 147721)


--- trunk/Source/WebCore/editing/EditingBehavior.h	2013-04-05 07:55:23 UTC (rev 147720)
+++ trunk/Source/WebCore/editing/EditingBehavior.h	2013-04-05 08:02:32 UTC (rev 147721)
@@ -64,14 +64,9 @@
     bool shouldSelectOnContextualMenuClick() const { return m_type == EditingMacBehavior; }
 
     // On Linux, should be able to get and insert spelling suggestions without selecting the misspelled word.
-    // Skip this policy for Chromium, they require selection for the misspelled word.
     bool shouldAllowSpellingSuggestionsWithoutSelection() const
     {
-#if !PLATFORM(CHROMIUM)
         return m_type == EditingUnixBehavior || m_type == EditingAndroidBehavior;
-#else
-        return false;
-#endif
     }
     
     // On Mac and Windows, pressing backspace (when it isn't handled otherwise) should navigate back.

Modified: trunk/Source/WebCore/editing/FrameSelection.h (147720 => 147721)


--- trunk/Source/WebCore/editing/FrameSelection.h	2013-04-05 07:55:23 UTC (rev 147720)
+++ trunk/Source/WebCore/editing/FrameSelection.h	2013-04-05 08:02:32 UTC (rev 147721)
@@ -329,7 +329,7 @@
     m_typingStyle = style;
 }
 
-#if !(PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(CHROMIUM) || PLATFORM(EFL))
+#if !(PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL))
 inline void FrameSelection::notifyAccessibilityForSelectionChange()
 {
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to