[webkit-changes] [147740] trunk/Source/WebKit/blackberry

Fri, 05 Apr 2013 05:48:58 -0700

Title: [147740] trunk/Source/WebKit/blackberry
Revision
147740
Author
commit-qu...@webkit.org
Date
2013-04-05 05:50:46 -0700 (Fri, 05 Apr 2013)

Log Message

[BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
https://bugs.webkit.org/show_bug.cgi?id=114022

Patch by Alberto Garcia <agar...@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

Naming the 'time' and 'inClip' unused parameters only produces
compiler warnings.

* Api/WebOverlay_p.h:
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(WebOverlayPrivateWebKitThread):
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
(BlackBerry::WebKit::WebPagePrivate::paintContents):
* WebKitSupport/DefaultTapHighlight.h:
(BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
* WebKitSupport/InspectorOverlayBlackBerry.cpp:
(BlackBerry::WebKit::InspectorOverlay::paintContents):
* WebKitSupport/InspectorOverlayBlackBerry.h:
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
(InspectorOverlay):
* WebKitSupport/SelectionOverlay.h:
(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebOverlay_p.h (147739 => 147740)


--- trunk/Source/WebKit/blackberry/Api/WebOverlay_p.h	2013-04-05 12:38:41 UTC (rev 147739)
+++ trunk/Source/WebKit/blackberry/Api/WebOverlay_p.h	2013-04-05 12:50:46 UTC (rev 147740)
@@ -166,9 +166,9 @@
     virtual WebCore::GraphicsLayer* graphicsLayer() const { return m_layer.get(); }
 
     // GraphicsLayerClient
-    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
+    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
     virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
-    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
+    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
 
 private:
     OwnPtr<WebCore::GraphicsLayer> m_layer;

Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (147739 => 147740)


--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2013-04-05 12:38:41 UTC (rev 147739)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2013-04-05 12:50:46 UTC (rev 147740)
@@ -401,9 +401,9 @@
     WebCore::GraphicsLayer* overlayLayer();
 
     // Fallback GraphicsLayerClient implementation, used for various overlay layers.
-    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
+    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
     virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
-    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip) { }
+    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&) { }
 
     // WebKit thread, plumbed through from ChromeClientBlackBerry.
     void setRootLayerWebKitThread(WebCore::Frame*, WebCore::LayerWebKitThread*);

Modified: trunk/Source/WebKit/blackberry/ChangeLog (147739 => 147740)


--- trunk/Source/WebKit/blackberry/ChangeLog	2013-04-05 12:38:41 UTC (rev 147739)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-04-05 12:50:46 UTC (rev 147740)
@@ -1,5 +1,31 @@
 2013-04-05  Alberto Garcia  <agar...@igalia.com>
 
+        [BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
+        https://bugs.webkit.org/show_bug.cgi?id=114022
+
+        Reviewed by Carlos Garcia Campos.
+
+        Naming the 'time' and 'inClip' unused parameters only produces
+        compiler warnings.
+
+        * Api/WebOverlay_p.h:
+        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
+        (WebOverlayPrivateWebKitThread):
+        * Api/WebPage_p.h:
+        (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
+        (BlackBerry::WebKit::WebPagePrivate::paintContents):
+        * WebKitSupport/DefaultTapHighlight.h:
+        (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
+        * WebKitSupport/InspectorOverlayBlackBerry.cpp:
+        (BlackBerry::WebKit::InspectorOverlay::paintContents):
+        * WebKitSupport/InspectorOverlayBlackBerry.h:
+        (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
+        (InspectorOverlay):
+        * WebKitSupport/SelectionOverlay.h:
+        (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
+
+2013-04-05  Alberto Garcia  <agar...@igalia.com>
+
         [BlackBerry] WebOverlay: fix access to m_client
         https://bugs.webkit.org/show_bug.cgi?id=114003

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h (147739 => 147740)


--- trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h	2013-04-05 12:38:41 UTC (rev 147739)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h	2013-04-05 12:50:46 UTC (rev 147740)
@@ -54,7 +54,7 @@
     virtual bool shouldHideAfterScroll() const { return m_shouldHideAfterScroll; }
 
     // GraphicsLayerClient
-    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
+    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
     virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
     virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.cpp (147739 => 147740)


--- trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.cpp	2013-04-05 12:38:41 UTC (rev 147739)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.cpp	2013-04-05 12:50:46 UTC (rev 147740)
@@ -47,7 +47,7 @@
     m_webPage->notifyFlushRequired(layer);
 }
 
-void InspectorOverlay::paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext& context, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip)
+void InspectorOverlay::paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext& context, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&)
 {
     context.save();
     WebCore::IntPoint scrollPosition = m_webPage->focusedOrMainFrame()->view()->scrollPosition();

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.h (147739 => 147740)


--- trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.h	2013-04-05 12:38:41 UTC (rev 147739)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.h	2013-04-05 12:50:46 UTC (rev 147740)
@@ -51,9 +51,9 @@
     void paintWebFrame(WebCore::GraphicsContext&);
 
 #if USE(ACCELERATED_COMPOSITING)
-    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
+    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
     virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
-    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
+    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
 #endif
 
 private:

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.h (147739 => 147740)


--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.h	2013-04-05 12:38:41 UTC (rev 147739)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.h	2013-04-05 12:50:46 UTC (rev 147740)
@@ -54,7 +54,7 @@
     void hide();
 
     // GraphicsLayerClient
-    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
+    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
     virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
     virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
 

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to