Title: [147743] trunk/Source/WTF
Revision
147743
Author
[email protected]
Date
2013-04-05 06:42:35 -0700 (Fri, 05 Apr 2013)

Log Message

[EFL] Disable GLOBAL_FAST_MALLOC_NEW by default.
https://bugs.webkit.org/show_bug.cgi?id=114031

Reviewed by Alexis Menard.

Follow what some other ports already do and avoid globally overriding
the `new' and `delete' operators with the ones in FastMalloc.

In many cases, third-party or client code allocates memory with
standard library calls but the memory gets deleted by FastMalloc,
causing a crash. The reverse (ie. memory being allocated by FastMalloc
and freed by the system libraries) is also possible.

Commits 135666 and 121018 provide more information about this, as well
as comment 6 in bug 89358.

* wtf/Platform.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (147742 => 147743)


--- trunk/Source/WTF/ChangeLog	2013-04-05 13:26:01 UTC (rev 147742)
+++ trunk/Source/WTF/ChangeLog	2013-04-05 13:42:35 UTC (rev 147743)
@@ -1,3 +1,23 @@
+2013-04-05  Raphael Kubo da Costa  <[email protected]>
+
+        [EFL] Disable GLOBAL_FAST_MALLOC_NEW by default.
+        https://bugs.webkit.org/show_bug.cgi?id=114031
+
+        Reviewed by Alexis Menard.
+
+        Follow what some other ports already do and avoid globally overriding
+        the `new' and `delete' operators with the ones in FastMalloc.
+
+        In many cases, third-party or client code allocates memory with
+        standard library calls but the memory gets deleted by FastMalloc,
+        causing a crash. The reverse (ie. memory being allocated by FastMalloc
+        and freed by the system libraries) is also possible.
+
+        Commits 135666 and 121018 provide more information about this, as well
+        as comment 6 in bug 89358.
+
+        * wtf/Platform.h:
+
 2013-04-05  Benjamin Poulain  <[email protected]>
 
         Remove WTFURL from WebKit

Modified: trunk/Source/WTF/wtf/Platform.h (147742 => 147743)


--- trunk/Source/WTF/wtf/Platform.h	2013-04-05 13:26:01 UTC (rev 147742)
+++ trunk/Source/WTF/wtf/Platform.h	2013-04-05 13:42:35 UTC (rev 147743)
@@ -709,6 +709,10 @@
 #endif
 #endif
 
+#if PLATFORM(EFL)
+#define ENABLE_GLOBAL_FASTMALLOC_NEW 0
+#endif
+
 #if !defined(ENABLE_GLOBAL_FASTMALLOC_NEW)
 #define ENABLE_GLOBAL_FASTMALLOC_NEW 1
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to