Title: [147884] trunk/Source/WTF
- Revision
- 147884
- Author
- [email protected]
- Date
- 2013-04-07 16:00:28 -0700 (Sun, 07 Apr 2013)
Log Message
[WIN] Fix problems with export macros of AutodrainedPool
https://bugs.webkit.org/show_bug.cgi?id=114132
Reviewed by Geoffrey Garen.
Exporting an inline function results in an error with the MS compiler.
* wtf/AutodrainedPool.h:
(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):
(WTF::AutodrainedPool::~AutodrainedPool):
(WTF::AutodrainedPool::cycle):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (147883 => 147884)
--- trunk/Source/WTF/ChangeLog 2013-04-07 22:18:48 UTC (rev 147883)
+++ trunk/Source/WTF/ChangeLog 2013-04-07 23:00:28 UTC (rev 147884)
@@ -1,5 +1,20 @@
2013-04-07 Patrick Gansterer <[email protected]>
+ [WIN] Fix problems with export macros of AutodrainedPool
+ https://bugs.webkit.org/show_bug.cgi?id=114132
+
+ Reviewed by Geoffrey Garen.
+
+ Exporting an inline function results in an error with the MS compiler.
+
+ * wtf/AutodrainedPool.h:
+ (AutodrainedPool):
+ (WTF::AutodrainedPool::AutodrainedPool):
+ (WTF::AutodrainedPool::~AutodrainedPool):
+ (WTF::AutodrainedPool::cycle):
+
+2013-04-07 Patrick Gansterer <[email protected]>
+
[WinCE] Add workaround for UNUSED_PARAM()
https://bugs.webkit.org/show_bug.cgi?id=113440
Modified: trunk/Source/WTF/wtf/AutodrainedPool.h (147883 => 147884)
--- trunk/Source/WTF/wtf/AutodrainedPool.h 2013-04-07 22:18:48 UTC (rev 147883)
+++ trunk/Source/WTF/wtf/AutodrainedPool.h 2013-04-07 23:00:28 UTC (rev 147884)
@@ -38,10 +38,16 @@
class AutodrainedPool {
WTF_MAKE_NONCOPYABLE(AutodrainedPool);
public:
+#if PLATFORM(MAC)
WTF_EXPORT_PRIVATE explicit AutodrainedPool(int iterationLimit = 1);
WTF_EXPORT_PRIVATE ~AutodrainedPool();
-
+
WTF_EXPORT_PRIVATE void cycle();
+#else
+ explicit AutodrainedPool(int = 1) { }
+ ~AutodrainedPool() { }
+ void cycle() { }
+#endif
private:
#if PLATFORM(MAC)
@@ -51,16 +57,8 @@
#endif
};
-#if !PLATFORM(MAC)
-inline AutodrainedPool::AutodrainedPool(int) { }
-inline AutodrainedPool::~AutodrainedPool() { }
-inline void AutodrainedPool::cycle() { }
-#endif
-
} // namespace WTF
using WTF::AutodrainedPool;
#endif
-
-
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
