Title: [147926] trunk/LayoutTests
Revision
147926
Author
grao...@apple.com
Date
2013-04-08 10:23:37 -0700 (Mon, 08 Apr 2013)

Log Message

Stop skipping first part of test in LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
https://bugs.webkit.org/show_bug.cgi?id=104255

Updated test to match the one hosted by W3C which has corrected the reported error.

Reviewed by Eric Carlson.

* media/track/opera/interfaces/TextTrack/cues-expected.txt:
* media/track/opera/interfaces/TextTrack/cues.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (147925 => 147926)


--- trunk/LayoutTests/ChangeLog	2013-04-08 17:22:30 UTC (rev 147925)
+++ trunk/LayoutTests/ChangeLog	2013-04-08 17:23:37 UTC (rev 147926)
@@ -1,3 +1,15 @@
+2013-04-08  Antoine Quint  <grao...@apple.com>
+
+        Stop skipping first part of test in LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
+        https://bugs.webkit.org/show_bug.cgi?id=104255
+
+        Updated test to match the one hosted by W3C which has corrected the reported error.
+
+        Reviewed by Eric Carlson.
+
+        * media/track/opera/interfaces/TextTrack/cues-expected.txt:
+        * media/track/opera/interfaces/TextTrack/cues.html:
+
 2013-04-08  Youenn Fablet  <youe...@gmail.com>
 
         [GTK][EFL] HEAD requests changed to GET after 303 redirection

Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrack/cues-expected.txt (147925 => 147926)


--- trunk/LayoutTests/media/track/opera/interfaces/TextTrack/cues-expected.txt	2013-04-08 17:22:30 UTC (rev 147925)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrack/cues-expected.txt	2013-04-08 17:23:37 UTC (rev 147926)
@@ -1,4 +1,5 @@
 
+PASS TextTrack.cues, empty list 
 PASS TextTrack.cues, after addCue() 
 PASS TextTrack.cues, different modes 
 PASS TextTrack.cues, changing order 

Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrack/cues.html (147925 => 147926)


--- trunk/LayoutTests/media/track/opera/interfaces/TextTrack/cues.html	2013-04-08 17:22:30 UTC (rev 147925)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrack/cues.html	2013-04-08 17:23:37 UTC (rev 147926)
@@ -9,23 +9,17 @@
     window.t1 = video.addTextTrack('subtitles');
     window.track = document.createElement('track');
     track['default'] = true;
-    video.appendChild(track);
+    video.appendChild(track); // queues a task to "honor user preferences...", media element event task source
     window.t2 = track.track;
     window.t1_cues = t1.cues
     window.t2_cues = t2.cues
 });
-// Skipping this test due to https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066,
-// tracking uncommenting this when test is fixed with webkit.org/b/104255
-// test(function(){
-//     assert_equals(t1.cues, t1_cues, 't1.cues should return same object');
-//     assert_equals(t2.cues, t2_cues, 't2.cues should return same object');
-//     assert_not_equals(t1.cues, t2.cues, 't1.cues and t2.cues should be different objects');
-//     assert_not_equals(t1.cues, null, 't1.cues should not be null');
-//     assert_not_equals(t2.cues, null, 't2.cues should not be null');
-//     assert_equals(t1.cues.length, 0, 't1.cues should have length 0');
-//     assert_equals(t2.cues.length, 0, 't2.cues should have length 0');
-// }, document.title+', empty list');
 test(function(){
+    assert_equals(t1.cues, t1_cues, 't1.cues should return same object');
+    assert_not_equals(t1.cues, null, 't1.cues should not be null');
+    assert_equals(t1.cues.length, 0, 't1.cues should have length 0');
+}, document.title+', empty list');
+test(function(){
     var c = new TextTrackCue(0, 1, "text");
     c.id = "id";
     t1.addCue(c);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to