Modified: trunk/Source/WebKit2/ChangeLog (147992 => 147993)
--- trunk/Source/WebKit2/ChangeLog 2013-04-09 07:20:01 UTC (rev 147992)
+++ trunk/Source/WebKit2/ChangeLog 2013-04-09 07:30:09 UTC (rev 147993)
@@ -1,3 +1,23 @@
+2013-04-08 Grzegorz Czajkowski <[email protected]>
+
+ [WK2][EFL] Mark not implemented methods in TextCheckerEfl.
+ https://bugs.webkit.org/show_bug.cgi?id=112261
+
+ Reviewed by Anders Carlsson.
+
+ There's no need to call client's methods in TextCheckerEfl.cpp if they are not
+ implemented. Mark them as not implemented until we provide proper implementation.
+
+ * UIProcess/efl/TextCheckerEfl.cpp:
+ (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
+ (WebKit::TextChecker::setGrammarCheckingEnabled):
+ (WebKit::TextChecker::grammarCheckingEnabledStateChanged):
+ (WebKit::TextChecker::checkGrammarOfString):
+ (WebKit::TextChecker::spellingUIIsShowing):
+ (WebKit::TextChecker::toggleSpellingUIIsShowing):
+ (WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
+ (WebKit::TextChecker::updateSpellingUIWithGrammarString):
+
2013-04-08 Benjamin Poulain <[email protected]>
Remove HTML Notification
Modified: trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp (147992 => 147993)
--- trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp 2013-04-09 07:20:01 UTC (rev 147992)
+++ trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp 2013-04-09 07:30:09 UTC (rev 147993)
@@ -28,6 +28,7 @@
#include "config.h"
#include "TextChecker.h"
+#include "NotImplemented.h"
#include "TextCheckerState.h"
#if ENABLE(SPELLCHECK)
@@ -59,11 +60,8 @@
bool TextChecker::isContinuousSpellCheckingAllowed()
{
-#if ENABLE(SPELLCHECK)
- return WebTextChecker::shared()->client().continuousSpellCheckingAllowed();
-#else
+ notImplemented();
return false;
-#endif
}
void TextChecker::setContinuousSpellCheckingEnabled(bool isContinuousSpellCheckingEnabled)
@@ -79,17 +77,9 @@
#endif
}
-void TextChecker::setGrammarCheckingEnabled(bool isGrammarCheckingEnabled)
+void TextChecker::setGrammarCheckingEnabled(bool)
{
-#if ENABLE(SPELLCHECK)
- if (state().isGrammarCheckingEnabled == isGrammarCheckingEnabled)
- return;
-
- textCheckerState.isGrammarCheckingEnabled = isGrammarCheckingEnabled;
- WebTextChecker::shared()->client().setGrammarCheckingEnabled(isGrammarCheckingEnabled);
-#else
- UNUSED_PARAM(isGrammarCheckingEnabled);
-#endif
+ notImplemented();
}
void TextChecker::continuousSpellCheckingEnabledStateChanged(bool enabled)
@@ -97,13 +87,9 @@
TextChecker::setContinuousSpellCheckingEnabled(enabled);
}
-void TextChecker::grammarCheckingEnabledStateChanged(bool enabled)
+void TextChecker::grammarCheckingEnabledStateChanged(bool)
{
-#if ENABLE(SPELLCHECK)
- textCheckerState.isGrammarCheckingEnabled = enabled;
-#else
- UNUSED_PARAM(enabled);
-#endif
+ notImplemented();
}
int64_t TextChecker::uniqueSpellDocumentTag(WebPageProxy* page)
@@ -210,55 +196,30 @@
#endif
}
-void TextChecker::checkGrammarOfString(int64_t spellDocumentTag, const UChar* text, uint32_t length, Vector<GrammarDetail>& grammarDetails, int32_t& badGrammarLocation, int32_t& badGrammarLength)
+void TextChecker::checkGrammarOfString(int64_t, const UChar*, uint32_t, Vector<GrammarDetail>&, int32_t&, int32_t&)
{
-#if ENABLE(SPELLCHECK)
- WebTextChecker::shared()->client().checkGrammarOfString(spellDocumentTag, String(text, length), grammarDetails, badGrammarLocation, badGrammarLength);
-#else
- UNUSED_PARAM(spellDocumentTag);
- UNUSED_PARAM(text);
- UNUSED_PARAM(length);
- UNUSED_PARAM(grammarDetails);
- UNUSED_PARAM(badGrammarLocation);
- UNUSED_PARAM(badGrammarLength);
-#endif
+ notImplemented();
}
bool TextChecker::spellingUIIsShowing()
{
-#if ENABLE(SPELLCHECK)
- return WebTextChecker::shared()->client().spellingUIIsShowing();
-#else
+ notImplemented();
return false;
-#endif
}
void TextChecker::toggleSpellingUIIsShowing()
{
-#if ENABLE(SPELLCHECK)
- WebTextChecker::shared()->client().toggleSpellingUIIsShowing();
-#endif
+ notImplemented();
}
-void TextChecker::updateSpellingUIWithMisspelledWord(int64_t spellDocumentTag, const String& misspelledWord)
+void TextChecker::updateSpellingUIWithMisspelledWord(int64_t, const String&)
{
-#if ENABLE(SPELLCHECK)
- WebTextChecker::shared()->client().updateSpellingUIWithMisspelledWord(spellDocumentTag, misspelledWord);
-#else
- UNUSED_PARAM(spellDocumentTag);
- UNUSED_PARAM(misspelledWord);
-#endif
+ notImplemented();
}
-void TextChecker::updateSpellingUIWithGrammarString(int64_t spellDocumentTag, const String& badGrammarPhrase, const GrammarDetail& grammarDetail)
+void TextChecker::updateSpellingUIWithGrammarString(int64_t, const String&, const GrammarDetail&)
{
-#if ENABLE(SPELLCHECK)
- WebTextChecker::shared()->client().updateSpellingUIWithGrammarString(spellDocumentTag, badGrammarPhrase, grammarDetail);
-#else
- UNUSED_PARAM(spellDocumentTag);
- UNUSED_PARAM(badGrammarPhrase);
- UNUSED_PARAM(grammarDetail);
-#endif
+ notImplemented();
}
void TextChecker::getGuessesForWord(int64_t spellDocumentTag, const String& word, const String& , Vector<String>& guesses)
