Title: [148022] trunk
- Revision
- 148022
- Author
- [email protected]
- Date
- 2013-04-09 07:31:35 -0700 (Tue, 09 Apr 2013)
Log Message
[CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
https://bugs.webkit.org/show_bug.cgi?id=112582
Reviewed by Andreas Kling.
Source/WebKit/qt:
We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.
* WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.
Source/WebKit2:
We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.
LayoutTests:
Add test to measure if the time interval is coherent with the unit
of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.
* fast/animation/request-animation-frame-time-unit-expected.txt: Added.
* fast/animation/request-animation-frame-time-unit.html: Added.
* fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (148021 => 148022)
--- trunk/LayoutTests/ChangeLog 2013-04-09 14:14:58 UTC (rev 148021)
+++ trunk/LayoutTests/ChangeLog 2013-04-09 14:31:35 UTC (rev 148022)
@@ -1,3 +1,17 @@
+2013-04-09 Rafael Brandao <[email protected]>
+
+ [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
+ https://bugs.webkit.org/show_bug.cgi?id=112582
+
+ Reviewed by Andreas Kling.
+
+ Add test to measure if the time interval is coherent with the unit
+ of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.
+
+ * fast/animation/request-animation-frame-time-unit-expected.txt: Added.
+ * fast/animation/request-animation-frame-time-unit.html: Added.
+ * fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
+
2013-04-09 Lamarque V. Souza <[email protected]>
[WebSocket] Ignore incoming message in CLOSING state
Added: trunk/LayoutTests/fast/animation/request-animation-frame-time-unit-expected.txt (0 => 148022)
--- trunk/LayoutTests/fast/animation/request-animation-frame-time-unit-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-time-unit-expected.txt 2013-04-09 14:31:35 UTC (rev 148022)
@@ -0,0 +1,10 @@
+Tests time unit of requestAnimationFrame callback
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS isTimeUnitInMs is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/animation/request-animation-frame-time-unit.html (0 => 148022)
--- trunk/LayoutTests/fast/animation/request-animation-frame-time-unit.html (rev 0)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-time-unit.html 2013-04-09 14:31:35 UTC (rev 148022)
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+</head>
+<body>
+<script src=""
+</body>
+</html>
Added: trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js (0 => 148022)
--- trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js (rev 0)
+++ trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js 2013-04-09 14:31:35 UTC (rev 148022)
@@ -0,0 +1,31 @@
+description("Tests time unit of requestAnimationFrame callback");
+
+var isTimeUnitInMs = false;
+
+window.requestAnimationFrame(function(time) {
+ var callbackTimeRef = time;
+ var timeRefInMs = Date.now();
+
+ setTimeout(function() {
+ window.requestAnimationFrame(function(time) {
+ var delta = time - callbackTimeRef;
+ var deltaTimeInMs = Date.now() - timeRefInMs;
+ var toleranceInMs = 10;
+ isTimeUnitInMs = Math.abs(delta - deltaTimeInMs) <= toleranceInMs;
+ shouldBeTrue("isTimeUnitInMs");
+ isSuccessfullyParsed();
+
+ if (window.testRunner)
+ testRunner.notifyDone();
+ });
+
+ if (window.testRunner)
+ testRunner.display();
+ }, 1);
+});
+
+if (window.testRunner)
+ testRunner.display();
+
+if (window.testRunner)
+ testRunner.waitUntilDone();
Modified: trunk/Source/WebKit/qt/ChangeLog (148021 => 148022)
--- trunk/Source/WebKit/qt/ChangeLog 2013-04-09 14:14:58 UTC (rev 148021)
+++ trunk/Source/WebKit/qt/ChangeLog 2013-04-09 14:31:35 UTC (rev 148022)
@@ -1,3 +1,16 @@
+2013-04-09 Rafael Brandao <[email protected]>
+
+ [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
+ https://bugs.webkit.org/show_bug.cgi?id=112582
+
+ Reviewed by Andreas Kling.
+
+ We've been exposing different time unit for requestAnimationFrame because
+ of wrong conversion before serviceScriptedAnimations function calls.
+ Fixed it to use seconds instead of milliseconds.
+
+ * WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.
+
2013-04-08 Benjamin Poulain <[email protected]>
Remove HTML Notification
Modified: trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp (148021 => 148022)
--- trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp 2013-04-09 14:14:58 UTC (rev 148021)
+++ trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp 2013-04-09 14:31:35 UTC (rev 148022)
@@ -625,7 +625,7 @@
void ChromeClientQt::serviceScriptedAnimations()
{
- m_webPage->mainFrameAdapter()->frame->view()->serviceScriptedAnimations(convertSecondsToDOMTimeStamp(currentTime()));
+ m_webPage->mainFrameAdapter()->frame->view()->serviceScriptedAnimations(currentTime());
}
#endif
Modified: trunk/Source/WebKit2/ChangeLog (148021 => 148022)
--- trunk/Source/WebKit2/ChangeLog 2013-04-09 14:14:58 UTC (rev 148021)
+++ trunk/Source/WebKit2/ChangeLog 2013-04-09 14:31:35 UTC (rev 148022)
@@ -1,3 +1,17 @@
+2013-04-09 Rafael Brandao <[email protected]>
+
+ [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
+ https://bugs.webkit.org/show_bug.cgi?id=112582
+
+ Reviewed by Andreas Kling.
+
+ We've been exposing different time unit for requestAnimationFrame because
+ of wrong conversion before serviceScriptedAnimations function calls.
+ Fixed it to use seconds instead of milliseconds.
+
+ * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+ (WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.
+
2013-04-09 Michael Brüning <[email protected]>
[Qt][WK2] Remove obsolete QtWebPageFindClient forward declaration from qquickwebview_p.h.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp (148021 => 148022)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp 2013-04-09 14:14:58 UTC (rev 148021)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp 2013-04-09 14:31:35 UTC (rev 148022)
@@ -506,7 +506,7 @@
{
#if ENABLE(REQUEST_ANIMATION_FRAME) && !USE(REQUEST_ANIMATION_FRAME_TIMER) && !USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
// Make sure that any previously registered animation callbacks are being executed before we flush the layers.
- m_webPage->corePage()->mainFrame()->view()->serviceScriptedAnimations(convertSecondsToDOMTimeStamp(currentTime()));
+ m_webPage->corePage()->mainFrame()->view()->serviceScriptedAnimations(currentTime());
#endif
m_webPage->layoutIfNeeded();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
