Title: [148081] trunk/Source/WebCore
- Revision
- 148081
- Author
- [email protected]
- Date
- 2013-04-10 00:36:42 -0700 (Wed, 10 Apr 2013)
Log Message
REGRESSION (r147719): Failures in two a11y tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=114259
Reviewed by Ryosuke Niwa.
No new tests - covered by existing tests.
Partially revert r147719, restoring the possible creation of the AXObject cache
and the subsequent call to its handleFocusedUIElementChanged method. Removing this
code caused regressions in accessibility tests on the GTK port, so the comment about
the AXObject cache is adjusted accordingly.
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (148080 => 148081)
--- trunk/Source/WebCore/ChangeLog 2013-04-10 07:18:22 UTC (rev 148080)
+++ trunk/Source/WebCore/ChangeLog 2013-04-10 07:36:42 UTC (rev 148081)
@@ -1,3 +1,20 @@
+2013-04-10 Zan Dobersek <[email protected]>
+
+ REGRESSION (r147719): Failures in two a11y tests on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=114259
+
+ Reviewed by Ryosuke Niwa.
+
+ No new tests - covered by existing tests.
+
+ Partially revert r147719, restoring the possible creation of the AXObject cache
+ and the subsequent call to its handleFocusedUIElementChanged method. Removing this
+ code caused regressions in accessibility tests on the GTK port, so the comment about
+ the AXObject cache is adjusted accordingly.
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+
2013-04-09 Philippe Normand <[email protected]>
[GStreamer] playbin uri getter is invalid
Modified: trunk/Source/WebCore/dom/Document.cpp (148080 => 148081)
--- trunk/Source/WebCore/dom/Document.cpp 2013-04-10 07:18:22 UTC (rev 148080)
+++ trunk/Source/WebCore/dom/Document.cpp 2013-04-10 07:36:42 UTC (rev 148081)
@@ -3488,6 +3488,12 @@
}
}
+ if (!focusChangeBlocked && m_focusedNode) {
+ // Create the AXObject cache in a focus change because GTK relies on it.
+ if (AXObjectCache* cache = axObjectCache())
+ cache->handleFocusedUIElementChanged(oldFocusedNode.get(), newFocusedNode.get());
+ }
+
if (!focusChangeBlocked)
page()->chrome()->focusedNodeChanged(m_focusedNode.get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
