Title: [148096] trunk/Tools
- Revision
- 148096
- Author
- [email protected]
- Date
- 2013-04-10 08:44:29 -0700 (Wed, 10 Apr 2013)
Log Message
Removed an annoying message from svn-create-patch
https://bugs.webkit.org/show_bug.cgi?id=114332
Reviewed by Alexey Proskuryakov.
I see this message basically every time I write a patch, so it must not
be true.
* Scripts/svn-create-patch:
(generateDiff):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (148095 => 148096)
--- trunk/Tools/ChangeLog 2013-04-10 15:10:08 UTC (rev 148095)
+++ trunk/Tools/ChangeLog 2013-04-10 15:44:29 UTC (rev 148096)
@@ -1,3 +1,16 @@
+2013-04-09 Geoffrey Garen <[email protected]>
+
+ Removed an annoying message from svn-create-patch
+ https://bugs.webkit.org/show_bug.cgi?id=114332
+
+ Reviewed by Alexey Proskuryakov.
+
+ I see this message basically every time I write a patch, so it must not
+ be true.
+
+ * Scripts/svn-create-patch:
+ (generateDiff):
+
2013-04-10 Anton Obzhirov <[email protected]>
[GTK] Add support for Page Visibility
Modified: trunk/Tools/Scripts/svn-create-patch (148095 => 148096)
--- trunk/Tools/Scripts/svn-create-patch 2013-04-10 15:10:08 UTC (rev 148095)
+++ trunk/Tools/Scripts/svn-create-patch 2013-04-10 15:44:29 UTC (rev 148096)
@@ -101,18 +101,11 @@
my $svnRoot = determineSVNRoot();
my $prefix = chdirReturningRelativePath($svnRoot);
-my $patchSize = 0;
-
-# Generate the diffs, in a order chosen for easy reviewing.
+# Generate the diffs, in an order chosen for ease of reviewing.
for my $path (sort patchpathcmp values %diffFiles) {
- $patchSize += generateDiff($path, $prefix);
+ generateDiff($path, $prefix);
}
-if ($patchSize > 20480) {
- print STDERR "WARNING: Patch's size is " . int($patchSize/1024) . " kbytes.\n";
- print STDERR "Patches 20k or smaller are more likely to be reviewed. Larger patches may sit unreviewed for a long time.\n";
-}
-
exit 0;
# Overall sort, considering multiple criteria.
@@ -245,7 +238,6 @@
print "\n" if ($patch && $patch =~ m/\n\S+$/m);
outputBinaryContent($file);
}
- return length($patch);
}
sub generateFileList($\%)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
