Title: [148110] trunk/Tools
- Revision
- 148110
- Author
- [email protected]
- Date
- 2013-04-10 11:05:41 -0700 (Wed, 10 Apr 2013)
Log Message
[GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365
Reviewed by Martin Robinson.
Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.
* gtk/jhbuild.modules:
* gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/Tools/ChangeLog (148109 => 148110)
--- trunk/Tools/ChangeLog 2013-04-10 18:03:58 UTC (rev 148109)
+++ trunk/Tools/ChangeLog 2013-04-10 18:05:41 UTC (rev 148110)
@@ -1,3 +1,18 @@
+2013-04-10 Zan Dobersek <[email protected]>
+
+ [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
+ https://bugs.webkit.org/show_bug.cgi?id=114365
+
+ Reviewed by Martin Robinson.
+
+ Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
+ The patch addresses crashes in the tally_event_reply method. It is already committed into the
+ at-spi2-atk source tree and will be available with the next stable release, after which the
+ patch should be removed and the dependency version bumped.
+
+ * gtk/jhbuild.modules:
+ * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
+
2013-04-10 Brent Fulgham <[email protected]>
[WinCairo] Unreviewed build fix. Correct DropBox download link.
Modified: trunk/Tools/gtk/jhbuild.modules (148109 => 148110)
--- trunk/Tools/gtk/jhbuild.modules 2013-04-10 18:03:58 UTC (rev 148109)
+++ trunk/Tools/gtk/jhbuild.modules 2013-04-10 18:05:41 UTC (rev 148110)
@@ -240,6 +240,7 @@
<branch module="pub/GNOME/sources/at-spi2-atk/2.8/at-spi2-atk-2.8.0.tar.xz" version="2.8.0"
repo="ftp.gnome.org"
hash="sha256:4688acbc1474cda0aa49341f109ad0726603ce3e872cc6521c74931338c7ba20">
+ <patch file="at-spi2-atk-2.8.0-null-check-after-cleanup.patch" strip="1"/>
</branch>
<dependencies>
<dep package="glib"/>
Added: trunk/Tools/gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch (0 => 148110)
--- trunk/Tools/gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch (rev 0)
+++ trunk/Tools/gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch 2013-04-10 18:05:41 UTC (rev 148110)
@@ -0,0 +1,22 @@
+From 5de2b2bc9c83045a6870e13cd20bc3c2c0a1121f Mon Sep 17 00:00:00 2001
+From: Mike Gorse <[email protected]>
+Date: Wed, 10 Apr 2013 17:40:47 +0000
+Subject: Add NULL check to fix crash when receiving a dbus reply after cleanup
+
+---
+diff --git a/atk-adaptor/bridge.c b/atk-adaptor/bridge.c
+index 9683e18..b016da6 100644
+--- a/atk-adaptor/bridge.c
++++ b/atk-adaptor/bridge.c
+@@ -88,6 +88,9 @@ tally_event_reply ()
+ {
+ static int replies_received = 0;
+
++ if (!spi_global_app_data)
++ return;
++
+ replies_received++;
+ if (replies_received == 3)
+ {
+--
+cgit v0.9.1
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
