Title: [148153] trunk/Websites/bugs.webkit.org
- Revision
- 148153
- Author
- [email protected]
- Date
- 2013-04-10 17:00:32 -0700 (Wed, 10 Apr 2013)
Log Message
Bugzilla should show bubbles from webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114391
Reviewed by Benjamin Poulain.
Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.
* code-review.js:
* template/en/custom/attachment/edit.html.tmpl:
* template/en/custom/attachment/list.html.tmpl:
* template/en/custom/attachment/reviewform.html.tmpl:
Modified Paths
Diff
Modified: trunk/Websites/bugs.webkit.org/ChangeLog (148152 => 148153)
--- trunk/Websites/bugs.webkit.org/ChangeLog 2013-04-10 23:53:42 UTC (rev 148152)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2013-04-11 00:00:32 UTC (rev 148153)
@@ -1,3 +1,17 @@
+2013-04-10 Ryosuke Niwa <[email protected]>
+
+ Bugzilla should show bubbles from webkit-queues.appspot.com
+ https://bugs.webkit.org/show_bug.cgi?id=114391
+
+ Reviewed by Benjamin Poulain.
+
+ Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.
+
+ * code-review.js:
+ * template/en/custom/attachment/edit.html.tmpl:
+ * template/en/custom/attachment/list.html.tmpl:
+ * template/en/custom/attachment/reviewform.html.tmpl:
+
2013-03-21 Ryosuke Niwa <[email protected]>
EWS bubbles need more space
Modified: trunk/Websites/bugs.webkit.org/code-review.js (148152 => 148153)
--- trunk/Websites/bugs.webkit.org/code-review.js 2013-04-10 23:53:42 UTC (rev 148152)
+++ trunk/Websites/bugs.webkit.org/code-review.js 2013-04-11 00:00:32 UTC (rev 148153)
@@ -547,6 +547,7 @@
function handleStatusBubbleLoad(e) {
e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-commit-queue.appspot.com');
+ e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.appspot.com');
}
function fetchHistory() {
@@ -581,6 +582,14 @@
statusBubble._onload_ = handleStatusBubbleLoad;
$('#statusBubbleContainer').append(statusBubble);
+ statusBubble = document.createElement('iframe');
+ statusBubble.className = 'statusBubble';
+ statusBubble.src = '' + attachment_id;
+ statusBubble.scrolling = 'no';
+ // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
+ statusBubble._onload_ = handleStatusBubbleLoad;
+ $('#statusBubbleContainer').append(statusBubble);
+
$('#toolbar .bugLink').html('<a href="" + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');
});
}
Modified: trunk/Websites/bugs.webkit.org/template/en/custom/attachment/edit.html.tmpl (148152 => 148153)
--- trunk/Websites/bugs.webkit.org/template/en/custom/attachment/edit.html.tmpl 2013-04-10 23:53:42 UTC (rev 148152)
+++ trunk/Websites/bugs.webkit.org/template/en/custom/attachment/edit.html.tmpl 2013-04-11 00:00:32 UTC (rev 148153)
@@ -264,6 +264,9 @@
<iframe src="" attachment.id %]"
style="width: 480px; height: 40px; border: none;" scrolling="no">
</iframe>
+ <iframe src="" attachment.id %]"
+ style="width: 480px; height: 40px; border: none;" scrolling="no">
+ </iframe>
</div>
<br>
[% END %]
Modified: trunk/Websites/bugs.webkit.org/template/en/custom/attachment/list.html.tmpl (148152 => 148153)
--- trunk/Websites/bugs.webkit.org/template/en/custom/attachment/list.html.tmpl 2013-04-10 23:53:42 UTC (rev 148152)
+++ trunk/Websites/bugs.webkit.org/template/en/custom/attachment/list.html.tmpl 2013-04-11 00:00:32 UTC (rev 148153)
@@ -156,8 +156,11 @@
[% END %]
<div class="statusBubble">
<iframe src="" attachment.id %]"
- style="width: 600px; height: 20px; border: none;" scrolling="no">
+ style="width: 450px; height: 20px; border: none;" scrolling="no">
</iframe>
+ <iframe src="" attachment.id %]"
+ style="width: 450px; height: 20px; border: none;" scrolling="no">
+ </iframe>
</div>
[% END %]
[%# endif // WEBKIT_CHANGES %]
Modified: trunk/Websites/bugs.webkit.org/template/en/custom/attachment/reviewform.html.tmpl (148152 => 148153)
--- trunk/Websites/bugs.webkit.org/template/en/custom/attachment/reviewform.html.tmpl 2013-04-10 23:53:42 UTC (rev 148152)
+++ trunk/Websites/bugs.webkit.org/template/en/custom/attachment/reviewform.html.tmpl 2013-04-11 00:00:32 UTC (rev 148153)
@@ -113,6 +113,9 @@
<iframe src="" attachment.id %]"
style="width: 450px; height: 20px; border: none;" scrolling="no">
</iframe>
+ <iframe src="" attachment.id %]"
+ style="width: 450px; height: 20px; border: none;" scrolling="no">
+ </iframe>
</div>
</td>
</tr>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
