Title: [148170] trunk/Source/WebCore
- Revision
- 148170
- Author
- [email protected]
- Date
- 2013-04-10 20:53:24 -0700 (Wed, 10 Apr 2013)
Log Message
Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114351
Reviewed by Ryosuke Niwa.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
* Modules/webaudio/AudioBufferSourceNode.idl:
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/AudioParam.idl:
* Modules/webaudio/OscillatorNode.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (148169 => 148170)
--- trunk/Source/WebCore/ChangeLog 2013-04-11 03:23:26 UTC (rev 148169)
+++ trunk/Source/WebCore/ChangeLog 2013-04-11 03:53:24 UTC (rev 148170)
@@ -1,5 +1,19 @@
2013-04-10 Patrick Gansterer <[email protected]>
+ Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
+ https://bugs.webkit.org/show_bug.cgi?id=114351
+
+ Reviewed by Ryosuke Niwa.
+
+ The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
+
+ * Modules/webaudio/AudioBufferSourceNode.idl:
+ * Modules/webaudio/AudioContext.idl:
+ * Modules/webaudio/AudioParam.idl:
+ * Modules/webaudio/OscillatorNode.idl:
+
+2013-04-10 Patrick Gansterer <[email protected]>
+
Replace ENABLE_DIRECTORY_UPLOAD preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114350
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl (148169 => 148170)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl 2013-04-11 03:23:26 UTC (rev 148169)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl 2013-04-11 03:53:24 UTC (rev 148170)
@@ -50,11 +50,9 @@
[ImplementedAs=startGrain] void start(in double when, in double grainOffset, in double grainDuration);
void stop(in double when);
-#if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
- attribute boolean looping; // This is an alias for the .loop attribute for backwards compatibility.
+ [Conditional=LEGACY_WEB_AUDIO] attribute boolean looping; // This is an alias for the .loop attribute for backwards compatibility.
- void noteOn(in double when);
- void noteGrainOn(in double when, in double grainOffset, in double grainDuration);
- void noteOff(in double when);
-#endif
+ [Conditional=LEGACY_WEB_AUDIO] void noteOn(in double when);
+ [Conditional=LEGACY_WEB_AUDIO] void noteGrainOn(in double when, in double grainOffset, in double grainDuration);
+ [Conditional=LEGACY_WEB_AUDIO] void noteOff(in double when);
};
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.idl (148169 => 148170)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.idl 2013-04-11 03:23:26 UTC (rev 148169)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.idl 2013-04-11 03:53:24 UTC (rev 148170)
@@ -94,13 +94,11 @@
attribute EventListener oncomplete;
void startRendering();
-#if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
- [ImplementedAs=createGain] GainNode createGainNode();
- [ImplementedAs=createDelay] DelayNode createDelayNode(in [Optional] double maxDelayTime)
+ [Conditional=LEGACY_WEB_AUDIO, ImplementedAs=createGain] GainNode createGainNode();
+ [Conditional=LEGACY_WEB_AUDIO, ImplementedAs=createDelay] DelayNode createDelayNode(in [Optional] double maxDelayTime)
raises(DOMException);
- [ImplementedAs=createScriptProcessor] ScriptProcessorNode createJavaScriptNode(in unsigned long bufferSize, in [Optional] unsigned long numberOfInputChannels, in [Optional] unsigned long numberOfOutputChannels)
+ [Conditional=LEGACY_WEB_AUDIO, ImplementedAs=createScriptProcessor] ScriptProcessorNode createJavaScriptNode(in unsigned long bufferSize, in [Optional] unsigned long numberOfInputChannels, in [Optional] unsigned long numberOfOutputChannels)
raises(DOMException);
-#endif
};
Modified: trunk/Source/WebCore/Modules/webaudio/AudioParam.idl (148169 => 148170)
--- trunk/Source/WebCore/Modules/webaudio/AudioParam.idl 2013-04-11 03:23:26 UTC (rev 148169)
+++ trunk/Source/WebCore/Modules/webaudio/AudioParam.idl 2013-04-11 03:53:24 UTC (rev 148170)
@@ -54,8 +54,6 @@
// Cancels all scheduled parameter changes with times greater than or equal to startTime.
void cancelScheduledValues(in float startTime);
-#if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
- [ImplementedAs=setTargetAtTime] void setTargetValueAtTime(in float targetValue, in float time, in float timeConstant);
-#endif
+ [Conditional=LEGACY_WEB_AUDIO, ImplementedAs=setTargetAtTime] void setTargetValueAtTime(in float targetValue, in float time, in float timeConstant);
};
Modified: trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl (148169 => 148170)
--- trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl 2013-04-11 03:23:26 UTC (rev 148169)
+++ trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl 2013-04-11 03:53:24 UTC (rev 148170)
@@ -51,10 +51,8 @@
void start(in double when);
void stop(in double when);
-#if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
- void noteOn(in double when);
- void noteOff(in double when);
-#endif
+ [Conditional=LEGACY_WEB_AUDIO] void noteOn(in double when);
+ [Conditional=LEGACY_WEB_AUDIO] void noteOff(in double when);
void setWaveTable(in WaveTable waveTable);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
