Title: [148181] trunk/Tools
Revision
148181
Author
[email protected]
Date
2013-04-11 00:45:34 -0700 (Thu, 11 Apr 2013)

Log Message

Fix roll-chromium-deps and hi.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):
(RollChromiumDEPS.execute):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (148180 => 148181)


--- trunk/Tools/ChangeLog	2013-04-11 07:40:29 UTC (rev 148180)
+++ trunk/Tools/ChangeLog	2013-04-11 07:45:34 UTC (rev 148181)
@@ -1,5 +1,13 @@
 2013-04-11  Ryosuke Niwa  <[email protected]>
 
+        Fix roll-chromium-deps and hi.
+
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        (Hi.execute):
+        (RollChromiumDEPS.execute):
+
+2013-04-11  Ryosuke Niwa  <[email protected]>
+
         Remove webkitpy code to roll Chromium DEPS
         https://bugs.webkit.org/show_bug.cgi?id=114415
 

Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (148180 => 148181)


--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2013-04-11 07:40:29 UTC (rev 148180)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2013-04-11 07:45:34 UTC (rev 148181)
@@ -114,6 +114,8 @@
     help_string = "Retrieves a random quip from Bugzilla."
 
     def execute(self, nick, args, tool, sheriff):
+        if len(args) and args[0] == 'webkitbot!':
+            return "%s: hi %s!" % (nick, nick)
         quips = tool.bugs.quips()
         quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
         return random.choice(quips)
@@ -133,13 +135,11 @@
     help_string = "Rolls WebKit's Chromium DEPS to the given revision???"
 
     def execute(self, nick, args, tool, sheriff):
-        revision = self._parse_args(args)
-        if not revision:
+        if not len(args):
             return self.usage(nick)
+        return "%s: Thank You." % nick
 
-        tool.irc().post("%s: Thank You." % nick)
 
-
 class Rollout(IRCCommand):
     usage_string = "rollout SVN_REVISION [SVN_REVISIONS] REASON"
     help_string = "Opens a rollout bug, CCing author + reviewer, and attaching the reverse-diff of the given revisions marked as commit-queue=?."
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to