Title: [148194] trunk/Source/WebCore
Revision
148194
Author
[email protected]
Date
2013-04-11 04:37:53 -0700 (Thu, 11 Apr 2013)

Log Message

IconDatabase: Simplify boolean logic in assertion.
https://bugs.webkit.org/show_bug.cgi?id=114425

Reviewed by Andreas Kling.

Follow-up to r148097; drop the overzealous use of !! to turn a
PassRefPtr into a boolean.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (148193 => 148194)


--- trunk/Source/WebCore/ChangeLog	2013-04-11 11:28:13 UTC (rev 148193)
+++ trunk/Source/WebCore/ChangeLog	2013-04-11 11:37:53 UTC (rev 148194)
@@ -1,3 +1,16 @@
+2013-04-11  Raphael Kubo da Costa  <[email protected]>
+
+        IconDatabase: Simplify boolean logic in assertion.
+        https://bugs.webkit.org/show_bug.cgi?id=114425
+
+        Reviewed by Andreas Kling.
+
+        Follow-up to r148097; drop the overzealous use of !! to turn a
+        PassRefPtr into a boolean.
+
+        * loader/icon/IconDatabase.cpp:
+        (WebCore::IconDatabase::updateIconRecord):
+
 2013-04-11  Arvid Nilsson  <[email protected]>
 
         [BlackBerry] LayerTexture refactoring

Modified: trunk/Source/WebCore/loader/icon/IconDatabase.cpp (148193 => 148194)


--- trunk/Source/WebCore/loader/icon/IconDatabase.cpp	2013-04-11 11:28:13 UTC (rev 148193)
+++ trunk/Source/WebCore/loader/icon/IconDatabase.cpp	2013-04-11 11:37:53 UTC (rev 148194)
@@ -538,7 +538,7 @@
 void IconDatabase::updateIconRecord(PassRefPtr<SharedBuffer> iconData, PassRefPtr<Image> iconBitmap, const String& iconURL)
 {
     // Only one of iconData or iconBitmap should be provided, never both. None is also fine.
-    ASSERT(!(!!iconData && !!iconBitmap));
+    ASSERT(!(iconData && iconBitmap));
 
     Vector<String> pageURLs;
     {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to