Title: [148236] trunk
- Revision
- 148236
- Author
- [email protected]
- Date
- 2013-04-11 14:41:28 -0700 (Thu, 11 Apr 2013)
Log Message
MutationRecord is not exposed
https://bugs.webkit.org/show_bug.cgi?id=114288
Patch by Sukolsak Sakshuwong <[email protected]> on 2013-04-11
Reviewed by Darin Adler.
Source/WebCore:
Expose MutationRecord on DOMWindow. This patch is copied from a patch
by Adam Klein. https://codereview.chromium.org/13861028
Test: fast/dom/MutationObserver/mutation-record-constructor.html
* page/DOMWindow.idl:
LayoutTests:
This test is copied from a patch by Adam Klein.
https://codereview.chromium.org/13861028
The test expectation of "typeof MutationRecord" is changed from
"function" to "object". (See bug 114457)
* fast/dom/MutationObserver/mutation-record-constructor-expected.txt: Added.
* fast/dom/MutationObserver/mutation-record-constructor.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (148235 => 148236)
--- trunk/LayoutTests/ChangeLog 2013-04-11 21:28:55 UTC (rev 148235)
+++ trunk/LayoutTests/ChangeLog 2013-04-11 21:41:28 UTC (rev 148236)
@@ -1,3 +1,18 @@
+2013-04-11 Sukolsak Sakshuwong <[email protected]>
+
+ MutationRecord is not exposed
+ https://bugs.webkit.org/show_bug.cgi?id=114288
+
+ Reviewed by Darin Adler.
+
+ This test is copied from a patch by Adam Klein.
+ https://codereview.chromium.org/13861028
+ The test expectation of "typeof MutationRecord" is changed from
+ "function" to "object". (See bug 114457)
+
+ * fast/dom/MutationObserver/mutation-record-constructor-expected.txt: Added.
+ * fast/dom/MutationObserver/mutation-record-constructor.html: Added.
+
2013-04-11 Dirk Schulze <[email protected]>
[CSS Shaders] Parse parameters descriptor
Added: trunk/LayoutTests/fast/dom/MutationObserver/mutation-record-constructor-expected.txt (0 => 148236)
--- trunk/LayoutTests/fast/dom/MutationObserver/mutation-record-constructor-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/MutationObserver/mutation-record-constructor-expected.txt 2013-04-11 21:41:28 UTC (rev 148236)
@@ -0,0 +1,13 @@
+MutationRecord should be exposed on window but not constructible
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.MutationRecord is non-null.
+PASS typeof MutationRecord is "object"
+PASS new MutationRecord threw exception TypeError: '[object MutationRecordConstructor]' is not a constructor (evaluating 'new MutationRecord').
+PASS record instanceof MutationRecord is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/MutationObserver/mutation-record-constructor.html (0 => 148236)
--- trunk/LayoutTests/fast/dom/MutationObserver/mutation-record-constructor.html (rev 0)
+++ trunk/LayoutTests/fast/dom/MutationObserver/mutation-record-constructor.html 2013-04-11 21:41:28 UTC (rev 148236)
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<script src=""
+<script>
+description('MutationRecord should be exposed on window but not constructible');
+
+shouldBeNonNull('window.MutationRecord');
+shouldBe('typeof MutationRecord', '"object"');
+shouldThrow('new MutationRecord');
+
+var div = document.createElement('div');
+var observer = new MutationObserver(function(){});
+observer.observe(div, {attributes: true});
+div.id = 'foo';
+var record = observer.takeRecords()[0];
+shouldBeTrue('record instanceof MutationRecord');
+</script>
+<script src=""
Modified: trunk/Source/WebCore/ChangeLog (148235 => 148236)
--- trunk/Source/WebCore/ChangeLog 2013-04-11 21:28:55 UTC (rev 148235)
+++ trunk/Source/WebCore/ChangeLog 2013-04-11 21:41:28 UTC (rev 148236)
@@ -1,3 +1,17 @@
+2013-04-11 Sukolsak Sakshuwong <[email protected]>
+
+ MutationRecord is not exposed
+ https://bugs.webkit.org/show_bug.cgi?id=114288
+
+ Reviewed by Darin Adler.
+
+ Expose MutationRecord on DOMWindow. This patch is copied from a patch
+ by Adam Klein. https://codereview.chromium.org/13861028
+
+ Test: fast/dom/MutationObserver/mutation-record-constructor.html
+
+ * page/DOMWindow.idl:
+
2013-04-11 Beth Dakin <[email protected]>
Cannot scroll to footer on a page with overflow:hidden on the body
Modified: trunk/Source/WebCore/page/DOMWindow.idl (148235 => 148236)
--- trunk/Source/WebCore/page/DOMWindow.idl 2013-04-11 21:28:55 UTC (rev 148235)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2013-04-11 21:41:28 UTC (rev 148236)
@@ -791,6 +791,7 @@
attribute MutationObserverConstructor WebKitMutationObserver; // FIXME: Add metrics to determine when we can remove this.
attribute MutationObserverConstructor MutationObserver;
+ attribute MutationRecordConstructor MutationRecord;
[Conditional=MEDIA_SOURCE] attribute MediaSourceConstructor WebKitMediaSource;
[Conditional=MEDIA_SOURCE] attribute SourceBufferConstructor WebKitSourceBuffer;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
