Title: [148273] trunk/Source/WebCore
- Revision
- 148273
- Author
- [email protected]
- Date
- 2013-04-12 03:54:21 -0700 (Fri, 12 Apr 2013)
Log Message
Apply our MSVC 2012 optimizer bug workaround to all minor releases
https://bugs.webkit.org/show_bug.cgi?id=114436
Reviewed by Alexey Proskuryakov.
The bug has only been partially fixed in Update 2 but our Update 1 workaround
still avoids the crash.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::TextEncodingNameHash::equal):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (148272 => 148273)
--- trunk/Source/WebCore/ChangeLog 2013-04-12 10:28:09 UTC (rev 148272)
+++ trunk/Source/WebCore/ChangeLog 2013-04-12 10:54:21 UTC (rev 148273)
@@ -1,3 +1,16 @@
+2013-04-12 Jocelyn Turcotte <[email protected]>
+
+ Apply our MSVC 2012 optimizer bug workaround to all minor releases
+ https://bugs.webkit.org/show_bug.cgi?id=114436
+
+ Reviewed by Alexey Proskuryakov.
+
+ The bug has only been partially fixed in Update 2 but our Update 1 workaround
+ still avoids the crash.
+
+ * platform/text/TextEncodingRegistry.cpp:
+ (WebCore::TextEncodingNameHash::equal):
+
2013-04-12 Mark Rowe <[email protected]>
And again, with the correct case this time.
Modified: trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp (148272 => 148273)
--- trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp 2013-04-12 10:28:09 UTC (rev 148272)
+++ trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp 2013-04-12 10:54:21 UTC (rev 148273)
@@ -65,9 +65,9 @@
char c1;
char c2;
do {
-#if defined(_MSC_FULL_VER) && _MSC_FULL_VER == 170051106
- // Workaround for a bug in the VS2012 Update 1 optimizer, remove once the fix is released.
- // https://connect.microsoft.com/VisualStudio/feedback/details/777533/vs2012-c-optimizing-bug-when-using-inline-and-char-return-type-x86-target-only
+#if defined(_MSC_VER) && _MSC_VER == 1700
+ // Workaround for a bug in the VS2012 Update1 and Update2 optimizer, remove once the fix is released.
+ // https://connect.microsoft.com/VisualStudio/feedback/details/781189/vs2012-update-ctp4-c-optimizing-bug
c1 = toASCIILower(*s1++);
c2 = toASCIILower(*s2++);
if (c1 != c2)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
