Title: [148458] trunk/Source/WebCore
Revision
148458
Author
eric.carl...@apple.com
Date
2013-04-15 12:46:28 -0700 (Mon, 15 Apr 2013)

Log Message

HTMLMediaElement::removeTextTrack should clear track client
https://bugs.webkit.org/show_bug.cgi?id=114630

Reviewed by Jer Noble.

No new tests, this is clean-up that prevents a potential crash.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removeTextTrack): Clear the track client.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (148457 => 148458)


--- trunk/Source/WebCore/ChangeLog	2013-04-15 19:39:01 UTC (rev 148457)
+++ trunk/Source/WebCore/ChangeLog	2013-04-15 19:46:28 UTC (rev 148458)
@@ -1,3 +1,15 @@
+2013-04-15  Eric Carlson  <eric.carl...@apple.com>
+
+        HTMLMediaElement::removeTextTrack should clear track client
+        https://bugs.webkit.org/show_bug.cgi?id=114630
+
+        Reviewed by Jer Noble.
+
+        No new tests, this is clean-up that prevents a potential crash.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::removeTextTrack): Clear the track client.
+
 2013-04-15  Robert Hogan  <rob...@webkit.org>
 
         An inline element with an absolutely positioned child does not correctly calculate/render padding and margin

Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (148457 => 148458)


--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2013-04-15 19:39:01 UTC (rev 148457)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2013-04-15 19:46:28 UTC (rev 148458)
@@ -2933,6 +2933,7 @@
     TextTrackCueList* cues = track->cues();
     if (cues)
         textTrackRemoveCues(track, cues);
+    track->clearClient();
     m_textTracks->remove(track);
 
     closeCaptionTracksChanged();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to