Title: [148464] trunk/Source/WebKit2
- Revision
- 148464
- Author
- [email protected]
- Date
- 2013-04-15 14:04:57 -0700 (Mon, 15 Apr 2013)
Log Message
After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=114634
Reviewed by Tim Horton.
In Mountain Lion and previous, report that a view is "not visible" when its window
is not in the active space. This causes us to notify AVFoundation that its CAImageQueues
will not be serviced and results in not having the "catch up" behavior when returning
to the browser's space.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (148463 => 148464)
--- trunk/Source/WebKit2/ChangeLog 2013-04-15 20:32:40 UTC (rev 148463)
+++ trunk/Source/WebKit2/ChangeLog 2013-04-15 21:04:57 UTC (rev 148464)
@@ -1,3 +1,18 @@
+2013-04-15 Jer Noble <[email protected]>
+
+ After switching to another space and back, video races to catch up with audio
+ https://bugs.webkit.org/show_bug.cgi?id=114634
+
+ Reviewed by Tim Horton.
+
+ In Mountain Lion and previous, report that a view is "not visible" when its window
+ is not in the active space. This causes us to notify AVFoundation that its CAImageQueues
+ will not be serviced and results in not having the "catch up" behavior when returning
+ to the browser's space.
+
+ * UIProcess/API/mac/PageClientImpl.mm:
+ (WebKit::PageClientImpl::isViewVisible):
+
2013-04-15 Seulgi Kim <[email protected]>
Schedule rendering at regular interval (60fps)
Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm (148463 => 148464)
--- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2013-04-15 20:32:40 UTC (rev 148463)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2013-04-15 21:04:57 UTC (rev 148464)
@@ -197,6 +197,13 @@
if (![[m_wkView window] isVisible])
return false;
+#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 1080
+ // Mountain Lion and previous do not support occlusion notifications, and as such will
+ // continue to report as "visible" when not on the active space.
+ if (![[m_wkView window] isOnActiveSpace])
+ return false;
+#endif
+
if ([m_wkView isHiddenOrHasHiddenAncestor])
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
