Title: [148539] trunk
- Revision
- 148539
- Author
- [email protected]
- Date
- 2013-04-16 13:22:17 -0700 (Tue, 16 Apr 2013)
Log Message
dfn element should be exposed as AXGroup:AXDefinition
https://bugs.webkit.org/show_bug.cgi?id=108980
Patch by James Craig <[email protected]> on 2013-04-16
Reviewed by Chris Fleizach.
Source/WebCore:
dfn element now exposed as AXGroup:AXDefinition. Updated existing tests.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
dfn element now exposed as AXGroup:AXDefinition
* platform/mac/accessibility/role-subrole-roledescription-expected.txt:
* platform/mac/accessibility/role-subrole-roledescription.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (148538 => 148539)
--- trunk/LayoutTests/ChangeLog 2013-04-16 20:15:42 UTC (rev 148538)
+++ trunk/LayoutTests/ChangeLog 2013-04-16 20:22:17 UTC (rev 148539)
@@ -1,3 +1,15 @@
+2013-04-16 James Craig <[email protected]>
+
+ dfn element should be exposed as AXGroup:AXDefinition
+ https://bugs.webkit.org/show_bug.cgi?id=108980
+
+ Reviewed by Chris Fleizach.
+
+ dfn element now exposed as AXGroup:AXDefinition
+
+ * platform/mac/accessibility/role-subrole-roledescription-expected.txt:
+ * platform/mac/accessibility/role-subrole-roledescription.html:
+
2013-04-16 Jochen Eisinger <[email protected]>
Flaky Test: http/tests/security/cookies/third-party-cookie-blocking-user-action.html
Modified: trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt (148538 => 148539)
--- trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt 2013-04-16 20:15:42 UTC (rev 148538)
+++ trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt 2013-04-16 20:22:17 UTC (rev 148539)
@@ -80,9 +80,9 @@
AXRoleDescription:
PASS: dfn
- AXRole:
- AXSubrole:
- AXRoleDescription:
+ AXRole: AXGroup
+ AXSubrole: AXDefinition
+ AXRoleDescription: definition
PASS: dl
AXRole: AXList
Modified: trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription.html (148538 => 148539)
--- trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription.html 2013-04-16 20:15:42 UTC (rev 148538)
+++ trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription.html 2013-04-16 20:22:17 UTC (rev 148539)
@@ -26,7 +26,7 @@
<!-- skipped <datalist> -->
<del data-role="" data-subrole="" data-roledescription="" class="ex">X</del>
<!-- skipped <details/summary> http://webkit.org/b/108979 -->
-<!-- <dfn> http://webkit.org/b/108980 --><dfn data-role="" data-subrole="" data-roledescription="" class="ex">X</dfn>
+<dfn data-role="AXGroup" data-subrole="AXDefinition" data-roledescription="definition" class="ex">X</dfn>
<dl data-role="AXList" data-subrole="AXDescriptionList" data-alternatesubrole="AXDefinitionList" data-roledescription="description list" class="ex">
<dt data-role="AXGroup" data-subrole="AXTerm" data-roledescription="term" class="ex">X</dt>
<dd data-role="AXGroup" data-subrole="AXDescription" data-roledescription="description" class="ex">X</dd>
Modified: trunk/Source/WebCore/ChangeLog (148538 => 148539)
--- trunk/Source/WebCore/ChangeLog 2013-04-16 20:15:42 UTC (rev 148538)
+++ trunk/Source/WebCore/ChangeLog 2013-04-16 20:22:17 UTC (rev 148539)
@@ -1,3 +1,16 @@
+2013-04-16 James Craig <[email protected]>
+
+ dfn element should be exposed as AXGroup:AXDefinition
+ https://bugs.webkit.org/show_bug.cgi?id=108980
+
+ Reviewed by Chris Fleizach.
+
+ dfn element now exposed as AXGroup:AXDefinition. Updated existing tests.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
+ (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+
2013-04-16 Anders Carlsson <[email protected]>
Begin chipping away at ScriptState
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (148538 => 148539)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2013-04-16 20:15:42 UTC (rev 148538)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2013-04-16 20:22:17 UTC (rev 148539)
@@ -1299,6 +1299,10 @@
if (!getAttribute(MathMLNames::alttextAttr).isEmpty())
return false;
#endif
+
+ // Other non-ignored host language elements
+ if (node && node->hasTagName(dfnTag))
+ return false;
// By default, objects should be ignored so that the AX hierarchy is not
// filled with unnecessary items.
@@ -2532,6 +2536,9 @@
if (node && node->hasTagName(labelTag))
return LabelRole;
+ if (node && node->hasTagName(dfnTag))
+ return DefinitionRole;
+
if (node && node->hasTagName(divTag))
return DivRole;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
