Title: [148581] trunk/LayoutTests
- Revision
- 148581
- Author
- [email protected]
- Date
- 2013-04-16 17:07:28 -0700 (Tue, 16 Apr 2013)
Log Message
[CSS Shaders] Add a test with a vertex, fragment shader pair that compiles but don't link
https://bugs.webkit.org/show_bug.cgi?id=114636
Added a test to check that unavailable varyings in fragment shaders
don't lead to unexpected crashes due to linking errors.
The current implementation does not crash, and this makes sure it
won't in future.
Reviewed by Dean Jackson.
* css3/filters/custom/custom-filter-unavailable-varying-expected.html: Added.
* css3/filters/custom/custom-filter-unavailable-varying.html: Added.
* css3/filters/resources/unavailable-varying.fs: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (148580 => 148581)
--- trunk/LayoutTests/ChangeLog 2013-04-17 00:05:21 UTC (rev 148580)
+++ trunk/LayoutTests/ChangeLog 2013-04-17 00:07:28 UTC (rev 148581)
@@ -1,3 +1,19 @@
+2013-04-16 Michelangelo De Simone <[email protected]>
+
+ [CSS Shaders] Add a test with a vertex, fragment shader pair that compiles but don't link
+ https://bugs.webkit.org/show_bug.cgi?id=114636
+
+ Added a test to check that unavailable varyings in fragment shaders
+ don't lead to unexpected crashes due to linking errors.
+ The current implementation does not crash, and this makes sure it
+ won't in future.
+
+ Reviewed by Dean Jackson.
+
+ * css3/filters/custom/custom-filter-unavailable-varying-expected.html: Added.
+ * css3/filters/custom/custom-filter-unavailable-varying.html: Added.
+ * css3/filters/resources/unavailable-varying.fs: Added.
+
2013-04-16 Jessie Berlin <[email protected]>
[Mac] compositing/background-color/background-color-change-to-text.html fails on some bots
Added: trunk/LayoutTests/css3/filters/custom/custom-filter-unavailable-varying-expected.html (0 => 148581)
--- trunk/LayoutTests/css3/filters/custom/custom-filter-unavailable-varying-expected.html (rev 0)
+++ trunk/LayoutTests/css3/filters/custom/custom-filter-unavailable-varying-expected.html 2013-04-17 00:07:28 UTC (rev 148581)
@@ -0,0 +1,15 @@
+<!DOCTYPE HTML>
+<head>
+ <title>Unavailable varying</title>
+ <style type="text/css">
+ #filter-target {
+ width: 100px;
+ height: 100px;
+ background: rgb(0, 255, 0);
+ }
+ </style>
+</head>
+<body>
+ <div id="filter-target"></div>
+</body>
+</html>
Added: trunk/LayoutTests/css3/filters/custom/custom-filter-unavailable-varying.html (0 => 148581)
--- trunk/LayoutTests/css3/filters/custom/custom-filter-unavailable-varying.html (rev 0)
+++ trunk/LayoutTests/css3/filters/custom/custom-filter-unavailable-varying.html 2013-04-17 00:07:28 UTC (rev 148581)
@@ -0,0 +1,20 @@
+<!DOCTYPE HTML>
+<head>
+ <title>Unavailable varying</title>
+ <style type="text/css">
+ #filter-target {
+ width: 100px;
+ height: 100px;
+ background: rgb(0, 255, 0);
+ -webkit-filter: custom(none mix(url('../resources/unavailable-varying.fs') normal source-atop));
+ }
+ </style>
+</head>
+<body>
+ <!--
+ This is a negative test aimed to check we don't crash while linking a vertex shader against a fragment shader when the latter makes
+ use of an unavailable varying which is not being passed from the vertex shader.
+ -->
+ <div id="filter-target"></div>
+</body>
+</html>
Added: trunk/LayoutTests/css3/filters/resources/unavailable-varying.fs (0 => 148581)
--- trunk/LayoutTests/css3/filters/resources/unavailable-varying.fs (rev 0)
+++ trunk/LayoutTests/css3/filters/resources/unavailable-varying.fs 2013-04-17 00:07:28 UTC (rev 148581)
@@ -0,0 +1,8 @@
+precision mediump float;
+varying vec4 unavailable;
+
+void main ()
+{
+ css_MixColor = unavailable;
+}
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
