Title: [148625] trunk/Source/WTF
- Revision
- 148625
- Author
- [email protected]
- Date
- 2013-04-17 12:14:43 -0700 (Wed, 17 Apr 2013)
Log Message
REGRESSION(r148584): WebKit nightly builds don't load any page
https://bugs.webkit.org/show_bug.cgi?id=114752
Reviewed by Anders Carlsson.
We can't use C++ style (//) comments in Platform.h because WebKit2/DerivedSource.make doesn't know
how to strip it to be merged with *.sb.in to generate *.sb files. Specifically, we have:
# Some versions of clang incorrectly strip out // comments in c89 code.
# Use -traditional as a workaround, but only when needed since that causes
# other problems with later versions of clang.
ifeq ($(shell echo '//x' | $(CC) -E -P -x c -std=c89 - | grep x),)
TEXT_PREPROCESSOR_FLAGS=-E -P -x c -traditional -w
else
TEXT_PREPROCESSOR_FLAGS=-E -P -x c -std=c89 -w
endif
* wtf/Platform.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (148624 => 148625)
--- trunk/Source/WTF/ChangeLog 2013-04-17 19:14:30 UTC (rev 148624)
+++ trunk/Source/WTF/ChangeLog 2013-04-17 19:14:43 UTC (rev 148625)
@@ -1,3 +1,24 @@
+2013-04-17 Ryosuke Niwa <[email protected]>
+
+ REGRESSION(r148584): WebKit nightly builds don't load any page
+ https://bugs.webkit.org/show_bug.cgi?id=114752
+
+ Reviewed by Anders Carlsson.
+
+ We can't use C++ style (//) comments in Platform.h because WebKit2/DerivedSource.make doesn't know
+ how to strip it to be merged with *.sb.in to generate *.sb files. Specifically, we have:
+
+ # Some versions of clang incorrectly strip out // comments in c89 code.
+ # Use -traditional as a workaround, but only when needed since that causes
+ # other problems with later versions of clang.
+ ifeq ($(shell echo '//x' | $(CC) -E -P -x c -std=c89 - | grep x),)
+ TEXT_PREPROCESSOR_FLAGS=-E -P -x c -traditional -w
+ else
+ TEXT_PREPROCESSOR_FLAGS=-E -P -x c -std=c89 -w
+ endif
+
+ * wtf/Platform.h:
+
2013-04-17 Brent Fulgham <[email protected]>
[Windows, WinCairo] Remove Include Settings for Pthreads from WTF
Modified: trunk/Source/WTF/wtf/Platform.h (148624 => 148625)
--- trunk/Source/WTF/wtf/Platform.h 2013-04-17 19:14:30 UTC (rev 148624)
+++ trunk/Source/WTF/wtf/Platform.h 2013-04-17 19:14:43 UTC (rev 148625)
@@ -1027,11 +1027,10 @@
#endif
#if PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070)
-// Some platforms provide UI for suggesting autocorrection.
+/* Some platforms provide UI for suggesting autocorrection. */
#define WTF_USE_AUTOCORRECTION_PANEL 1
-// Some platforms use spelling and autocorrection markers to provide visual cue.
-// On such platform, if word with marker is edited, we need to remove the marker.
+/* Some platforms use spelling and autocorrection markers to provide visual cue. On such platform, if word with marker is edited, we need to remove the marker. */
#define WTF_USE_MARKER_REMOVAL_UPON_EDITING 1
-#endif // #if PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070)
+#endif /* #if PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070) */
#endif /* WTF_Platform_h */
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
