Title: [148631] trunk/Tools
- Revision
- 148631
- Author
- [email protected]
- Date
- 2013-04-17 13:39:22 -0700 (Wed, 17 Apr 2013)
Log Message
[Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
https://bugs.webkit.org/show_bug.cgi?id=114756
Patch by Zan Dobersek <[email protected]> on 2013-04-17
Reviewed by Ryosuke Niwa.
Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
constructing the results URL and removing the possible row addition containing the Chromium commit range that
only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
method.
* TestResultServer/static-dashboards/timeline_explorer.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (148630 => 148631)
--- trunk/Tools/ChangeLog 2013-04-17 20:14:33 UTC (rev 148630)
+++ trunk/Tools/ChangeLog 2013-04-17 20:39:22 UTC (rev 148631)
@@ -1,3 +1,17 @@
+2013-04-17 Zan Dobersek <[email protected]>
+
+ [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
+ https://bugs.webkit.org/show_bug.cgi?id=114756
+
+ Reviewed by Ryosuke Niwa.
+
+ Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
+ constructing the results URL and removing the possible row addition containing the Chromium commit range that
+ only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
+ method.
+
+ * TestResultServer/static-dashboards/timeline_explorer.js:
+
2013-04-17 Alberto Garcia <[email protected]>
media-stream and xslt are no longer configurable options in the GTK+ port
Modified: trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.js (148630 => 148631)
--- trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.js 2013-04-17 20:14:33 UTC (rev 148630)
+++ trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.js 2013-04-17 20:39:22 UTC (rev 148631)
@@ -111,11 +111,6 @@
console.log( 'Time to get test results by build: ' + (Date.now() - startTime));
}
-function shouldShowWebKitRevisionsOnly()
-{
- return isTipOfTreeWebKitBuilder();
-}
-
function updateTimelineForBuilder()
{
var builder = g_history.dashboardSpecificState.builder || currentBuilderGroup().defaultBuilder();
@@ -229,19 +224,12 @@
addRow('', '');
var master = builderMaster(builder);
var buildUrl = master.logPath(builder, results[BUILD_NUMBERS_KEY][index]);
- if (master.name == WEBKIT_BUILDER_MASTER) {
- var resultsUrl = 'http://build.webkit.org/results/' + builder + '/r' + results[WEBKIT_REVISIONS_KEY][index] +
- ' (' + results[BUILD_NUMBERS_KEY][index] + ')';
- } else {
- var resultsUrl = 'http://build.chromium.org/f/chromium/layout_test_results/' +
- currentBuilders()[builder] + '/' + results[CHROME_REVISIONS_KEY][index];
- }
+ var resultsUrl = 'http://build.webkit.org/results/' + builder + '/r' + results[WEBKIT_REVISIONS_KEY][index] +
+ ' (' + results[BUILD_NUMBERS_KEY][index] + ')';
addRow('Build:', '<a href="" + buildUrl + '" target="_blank">' + buildNumber + '</a> (<a href="" + resultsUrl + '" target="_blank">results</a>)');
- // Revision link(s)
- if (!shouldShowWebKitRevisionsOnly())
- addRow('Chromium change:', ui.html.chromiumRevisionLink(results, index));
+ // Revision link
addRow('WebKit change:', ui.html.webKitRevisionLink(results, index));
// Test status/counts
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
