Title: [148767] trunk/Source/_javascript_Core
- Revision
- 148767
- Author
- [email protected]
- Date
- 2013-04-19 14:02:21 -0700 (Fri, 19 Apr 2013)
Log Message
Rename JSStringJoiner::build() to join()
https://bugs.webkit.org/show_bug.cgi?id=114845
Patch by Benjamin Poulain <[email protected]> on 2013-04-19
Reviewed by Geoffrey Garen.
The method name build() came from StringBuilder history. It does not make much
sense on the StringJoiner.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::join):
* runtime/JSStringJoiner.h:
(JSStringJoiner):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (148766 => 148767)
--- trunk/Source/_javascript_Core/ChangeLog 2013-04-19 20:56:39 UTC (rev 148766)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-04-19 21:02:21 UTC (rev 148767)
@@ -1,3 +1,22 @@
+2013-04-19 Benjamin Poulain <[email protected]>
+
+ Rename JSStringJoiner::build() to join()
+ https://bugs.webkit.org/show_bug.cgi?id=114845
+
+ Reviewed by Geoffrey Garen.
+
+ The method name build() came from StringBuilder history. It does not make much
+ sense on the StringJoiner.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncToString):
+ (JSC::arrayProtoFuncToLocaleString):
+ (JSC::arrayProtoFuncJoin):
+ * runtime/JSStringJoiner.cpp:
+ (JSC::JSStringJoiner::join):
+ * runtime/JSStringJoiner.h:
+ (JSStringJoiner):
+
2013-04-19 Roger Fong <[email protected]>
Unreviewed. WebKit_Source is incorrectly set.
Modified: trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp (148766 => 148767)
--- trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2013-04-19 20:56:39 UTC (rev 148766)
+++ trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2013-04-19 21:02:21 UTC (rev 148767)
@@ -324,7 +324,7 @@
if (exec->hadException())
return JSValue::encode(jsUndefined());
}
- return JSValue::encode(stringJoiner.build(exec));
+ return JSValue::encode(stringJoiner.join(exec));
}
EncodedJSValue JSC_HOST_CALL arrayProtoFuncToLocaleString(ExecState* exec)
@@ -367,7 +367,7 @@
}
}
- return JSValue::encode(stringJoiner.build(exec));
+ return JSValue::encode(stringJoiner.join(exec));
}
EncodedJSValue JSC_HOST_CALL arrayProtoFuncJoin(ExecState* exec)
@@ -413,7 +413,7 @@
stringJoiner.append(String());
}
- return JSValue::encode(stringJoiner.build(exec));
+ return JSValue::encode(stringJoiner.join(exec));
}
EncodedJSValue JSC_HOST_CALL arrayProtoFuncConcat(ExecState* exec)
Modified: trunk/Source/_javascript_Core/runtime/JSStringJoiner.cpp (148766 => 148767)
--- trunk/Source/_javascript_Core/runtime/JSStringJoiner.cpp 2013-04-19 20:56:39 UTC (rev 148766)
+++ trunk/Source/_javascript_Core/runtime/JSStringJoiner.cpp 2013-04-19 21:02:21 UTC (rev 148767)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -94,7 +94,7 @@
return outputStringImpl.release();
}
-JSValue JSStringJoiner::build(ExecState* exec)
+JSValue JSStringJoiner::join(ExecState* exec)
{
if (!m_isValid)
return throwOutOfMemoryError(exec);
Modified: trunk/Source/_javascript_Core/runtime/JSStringJoiner.h (148766 => 148767)
--- trunk/Source/_javascript_Core/runtime/JSStringJoiner.h 2013-04-19 20:56:39 UTC (rev 148766)
+++ trunk/Source/_javascript_Core/runtime/JSStringJoiner.h 2013-04-19 21:02:21 UTC (rev 148767)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -40,7 +40,7 @@
JSStringJoiner(const String& separator, size_t stringCount);
void append(const String&);
- JSValue build(ExecState*);
+ JSValue join(ExecState*);
private:
String m_separator;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
